Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple files in appcast xml #5057

Closed
hanxue opened this issue Jun 25, 2014 · 4 comments
Closed

Multiple files in appcast xml #5057

hanxue opened this issue Jun 25, 2014 · 4 comments

Comments

@hanxue
Copy link
Contributor

hanxue commented Jun 25, 2014

I have submitted a PL #5056 and the site contains an appcast XML with multiple files

https://code.google.com/feeds/p/epub-2-pdf/downloads/basic

Is this format correct?

appcast 'https://code.google.com/feeds/p/epub-2-pdf/downloads/basic'

@alebcay
Copy link
Member

alebcay commented Jun 25, 2014

The website doesn't look like a Sparkle feed to me.

@vitorgalvao
Copy link
Member

That shouldn’t be a problem. On the roadmap, we have

find non-standard/non-Sparkle appcast URLs for all other self-updating apps (eg GitHub.app)

@rolandwalker
Copy link
Contributor

Thanks @hanxue! I had been wanting to start adding non-Sparkle appcasts.

In the future (after merging #4847), we could write this as

  appcast 'https://code.google.com/feeds/p/epub-2-pdf/downloads/basic',
          :format => :unknown

For now, could you throw a comment there for me to find later? Something like

  # non-Sparkle appcast
  appcast 'https://code.google.com/feeds/p/epub-2-pdf/downloads/basic'

hanxue added a commit to hanxue/caskroom that referenced this issue Jun 26, 2014
@hanxue
Copy link
Contributor Author

hanxue commented Jun 26, 2014

Thanks for the clarification. Oops, looks like my initial pull request was merged already. I am sending a new pull request with the comment as suggested by @rolandwalker

vitorgalvao added a commit that referenced this issue Jul 1, 2014
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants