Add tooling to check for HTTPS versions of cask URLs

[federicobond]

I saw some cask updates losing their https links and I though we could add a tool to migrate all those casks that have an HTTPS version of the download link (and maybe homepage too) available but are not currently using it.

[rolandwalker]

Yes, I mass converted some HTTP URLs to HTTPS at one point but didn't save the scripts I used to do so.

However, there was a flaw in my method, which is that I didn't detect when HTTPS gets redirected to HTTP. For those cases, it would be better to revert to HTTP.

[federicobond]

I spent a couple of minutes trying to work around the Cask::LinkChecker code. My initial idea was to implement some sort of brew cask checklinks --try-https that would raise a warning for Casks that have an HTTPs endpoint available but are not currently using it.

Unfortunately, the code in Cask::LinkChecker is too stateful to make that work as it is. So, I have two options: either remove the state from it (make it return a Cask::LinkChecker::Response object) or implement the checker outside of the core using brew cask _stanza url. What do you think?

[rolandwalker]

Your call: there are merits either way.

brew cask _stanza is theoretically unstable, but in practice I can't imagine why it would change.

[federicobond]

Status update: removing state from Cask::LinkChecker was too much work for relatively little gain so I created a small shell script to query the url stanza and look for a 2xx or 3xx return value using curl. There were some false positives but overall I managed to update almost 100 casks.

Should I submit a single PR with all these changes?

[rolandwalker]

A single PR is fine, though it is better if the PR contains one-commit-per Cask.

After a mass change, I usually try to keep a lookout for any user submissions that caught a merge conflict and fix that for the user manually.

(Odd that there were still so many – I must have forgotten something in #4967 or #4968.)

[vitorgalvao]

Closing for lack of implementation. This is can be revisited later.