Fix Zsh completion #583
Merged
Fix Zsh completion #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, trying to get completion for `brew services` results in `a completion function is not defined for command or alias: services` and no actual completions. This is because `#compdef brew` in _brew_services conflicts with an identical statement in _brew, causing Zsh's compinit to not load _brew_services at all. This commit fixes that by instead declaring that this file defines completion for `brew services` only.
|
@MikeMcQuaid are these generated or manual? |
|
@SMillerDev manual but would be good to get them generated eventually. |
SMillerDev
approved these changes
Aug 28, 2023
|
Thanks @marlonrichert ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, trying to get completion for
brew servicesresults ina completion function is not defined for command or alias: servicesand no actual completions. This is because#compdef brewin _brew_services conflicts with an identical statement in _brew, causing Zsh's compinit to not load _brew_services at all.This commit fixes that by instead declaring that this file defines completion for
brew servicesonly.