-
Notifications
You must be signed in to change notification settings - Fork 116
Open
Description
When setting up an gcs import bucket in a project. I noticed there wasn't a recursive_scan parameter compared to the s3 import method. I have confirmed in the UI that "Scan sub-folders" it's not enabled by default when such bucket it's setup via the sdk.
GCS Import Method:
def connect_google_import_storage(
self,
bucket: str,
prefix: Optional[str] = None,
regex_filter: Optional[str] = None,
use_blob_urls: Optional[bool] = True,
google_application_credentials: Optional[str] = None,
presign: Optional[bool] = True,
presign_ttl: Optional[int] = 1,
title: Optional[str] = "",
description: Optional[str] = "",
):
S3 Import Method:
def connect_s3_import_storage(
self,
bucket: str,
prefix: Optional[str] = None,
regex_filter: Optional[str] = None,
use_blob_urls: Optional[bool] = True,
presign: Optional[bool] = True,
presign_ttl: Optional[int] = 1,
title: Optional[str] = "",
description: Optional[str] = "",
aws_access_key_id: Optional[str] = None,
aws_secret_access_key: Optional[str] = None,
aws_session_token: Optional[str] = None,
region_name: Optional[str] = None,
s3_endpoint: Optional[str] = None,
recursive_scan: Optional[bool] = False, <------ parameter missing in gcs import method
):
It should be a simple fix, let me know if you'd like me to implement.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels