Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: be/local/shell.Spawn should use UserDataDir for workdir not /tmp #489

Open
starpit opened this issue Oct 30, 2024 · 0 comments
Open

feat: be/local/shell.Spawn should use UserDataDir for workdir not /tmp #489

starpit opened this issue Oct 30, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@starpit
Copy link
Member

starpit commented Oct 30, 2024

  1. we aren't cleaning up the ioutil.TempDir() that is used for the workdir
  2. avoid /tmp for long-running processes
  3. avoid /tmp because maybe minio is confused by it (search for O_DIRECT in the minio issues)

for 1, we can piggyback on killProcessGroupOnContextCancellation() and also auto-clean up when the process exits normally
@starpit starpit added the enhancement New feature or request label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@starpit