-
Notifications
You must be signed in to change notification settings - Fork 38
feat: Add data type wrappers #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,190 @@ | ||||||||||
| // Copyright (c) International Business Machines Corp. 2019 | ||||||||||
|
|
||||||||||
| // Permission is hereby granted, free of charge, to any person obtaining a copy of this software and | ||||||||||
| // associated documentation files (the "Software"), to deal in the Software without restriction, | ||||||||||
| // including without limitation the rights to use, copy, modify, merge, publish, distribute, | ||||||||||
| // sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is | ||||||||||
| // furnished to do so, subject to the following conditions: | ||||||||||
|
|
||||||||||
| // The above copyright notice and this permission notice shall be included in all copies or | ||||||||||
| // substantial portions of the Software. | ||||||||||
|
|
||||||||||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT | ||||||||||
| // NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND | ||||||||||
| // NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, | ||||||||||
| // DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||||||||||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. | ||||||||||
|
|
||||||||||
| /* | ||||||||||
| * From XMLSERVICEQUICK reference | ||||||||||
| * http://yips.idevcloud.com/wiki/index.php/XMLService/XMLSERVICEQuick | ||||||||||
| * | ||||||||||
| * data - data value name (tag) | ||||||||||
| * values - value, | ||||||||||
| * type | ||||||||||
| * 3i0 int8/byte D myint8 3i 0 | ||||||||||
| * 5i0 int16/short D myint16 5i 0 | ||||||||||
| * 10i0 int32/int D myint32 10i 0 | ||||||||||
| * 20i0 int64/int64 D myint64 20i 0 | ||||||||||
| * 3u0 uint8/ubyte D myint8 3u 0 | ||||||||||
| * 5u0 uint16/ushort D myint16 5u 0 | ||||||||||
| * 10u0 uint32/uint D myint32 10u 0 | ||||||||||
| * 20u0 uint64/uint64 D myint64 20u 0 | ||||||||||
| * 32a char D mychar 32a | ||||||||||
|
||||||||||
| * 32a char D mychar 32a | |
| * 32a char[32] D mychar 32a |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * 32a {varying2} varchar D mychar 32a varying | |
| * 32a {varying4} varchar4 D mychar 32a varying(4) | |
| * 32a (varying=2) varchar D mychar 32a varying | |
| * 32a (varying=4) varchar4 D mychar 32a varying(4) |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that it's case sensitive, but for consistency I think we should use lowercase f in the types returned here.
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems more clear as PackedDecimal. Same goes for Zoned later.
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these @returns be adjusted? They don't actually return a string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup these need to updated to return objects instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a header?
I think it would also be nicer to space out the columns a bit and maybe put in some separator bars. The RPG example is a bit close to the "C" example.