Skip to content

[WiP] Sen4Map inheritance class change to geobench-compatible datamodule and dataset classes#227

Closed
MinasMayth wants to merge 7 commits into
torchgeo:mainfrom
MinasMayth:main
Closed

[WiP] Sen4Map inheritance class change to geobench-compatible datamodule and dataset classes#227
MinasMayth wants to merge 7 commits into
torchgeo:mainfrom
MinasMayth:main

Conversation

@MinasMayth
Copy link
Copy Markdown

Issue first raised in #226, Sen4map dataclass and datamodule classes currently only inherit from pytorch lightning, which is functionally adequate for terratorch but will not work with benchmark. I have updated the datamodule class to inherit from NonGeoDataModule, which required a few extra changes.

To get the Sen4map datamodule class to work with inheritance from NonGeoDataModule I had to define a custom augmentation self.aug = AugmentationSequential(K.RandomEqualize3D(), data_keys=None), is this okay? What is the default augmentation and why does it only (seemingly) work for BCHW tensors and not BCDHW tensors?

hashim1 and others added 6 commits November 5, 2024 13:09
@Joao-L-S-Almeida
Copy link
Copy Markdown
Contributor

Hi, @MinasMayth. It seems this work has entered in permanent regime. Do you feel confident to send it for review or prefer continue editing it ?
If so, you may add me as reviewer.

@MinasMayth
Copy link
Copy Markdown
Author

MinasMayth commented Mar 6, 2025 via email

@Joao-L-S-Almeida
Copy link
Copy Markdown
Contributor

Thanks @MinasMayth . I'll keep your branch open and I'll try to continue it.

@romeokienzler
Copy link
Copy Markdown
Collaborator

@MinasMayth @Joao-L-S-Almeida closing due to inactivity, feel free top reopen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sen4Map inheritance class change to geobench-compatible datamodule and dataset classes

3 participants