Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render links for publish and preview once the request is successful #18

Open
algomaster99 opened this issue Jul 16, 2020 · 2 comments
Open

Comments

@algomaster99
Copy link
Member

algomaster99 commented Jul 16, 2020

Currently, we render the hyperlinks to the publish/preview pages in a toast that never closes. This is done because we want to ensure that the faculty doesn't miss the link and they can always click the link on time.

But one drawback to this approach is - let's say the faculty makes multiple edits and after each, they try to preview the page. The UI can easily become cluttered like this:
Screenshot from 2020-07-16 11-14-48

I suggest to just display toast for throwing errors or notifying if it is successful. But where exactly do we render these hyperlinks? I have three approaches in my mind.

  1. Pop a tooltip over the button and this tooltip can be faded when the link is clicked.
  2. Render "Here is the link" instead of the button and once it is clicked, hide the former and show the latter.
  3. We can send them the links via notification.

Open to more suggestions. Let's decide what's the best way to go.

Note: Resolving this issue will require a running setup of CMS and its APIs as well.

@Prernaswarna
Copy link
Member

I would like to work on it

@algomaster99
Copy link
Member Author

@Prernaswarna yeah, sure. How are you planning to approach this problem? Let's discuss this first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants