Skip to content

Allow defining the destination field in configuration #4

@amitds1997

Description

@amitds1997

I am trying to use this package to provide GitHub release pre-commit hook for selene just like StyLua.

The problem: selene release packages the binary selene and that conflicts with the top level folder selene in the repo. So, the error is:

IsADirectoryError: [Errno 21] Is a directory: '<local-path>/selene/selene'

This does not happen when using the CLI command because it allows specifying destination.

Reproduction steps

  1. Clone amitds1997/selene
  2. Run pip wheel . directly or in a virtualenv

Possible resolution

  1. Allow passing destination in pyproject configuration (source).
  2. Pass destination to download_asset call.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions