Fix native crash and dialog-type assertion in WebView dialog tests

The instrumentation suite crashed the app process with SIGABRT during the
WebViewDialogOverrideTest teardown (a deferred g_object_unref on the WebKit main
loop while ActivityScenario destroyed the activity). The trigger is the new focus
wiring: onFocusChanged now calls wpe_view_focus_in, which keeps the page active and
scheduling engine work, while WebViewTestActivity never released the WebView, so the
leaked active page raced the activity teardown.

- WebViewTestActivity: release the WebView in onDestroy() so the focused/active page
  is torn down deterministically per ActivityScenario recreation.
- WebView.destroy(): drop the platformView reference once the native WPEView has been
  invalidated, so a late onFocusChanged during teardown cannot touch it.
- nativeScriptDialogConfirm: only call webkit_script_dialog_confirm_set_confirmed for
  CONFIRM/BEFORE_UNLOAD dialogs (and set prompt text for PROMPT). Calling it for an
  alert/prompt tripped a g_return_if_fail CRITICAL in WebKit.

Author: alexgcastro

wpeview/src/androidTest/java/org/wpewebkit/wpeview/WebViewTestActivity.java

@@ -25,5 +25,17 @@ public void onCreate(Bundle savedInstanceState) {
         setContentView(linearLayout);
     }
 
+    @Override
+    public void onDestroy() {
+        // ActivityScenario recreates this activity for every test. Release the WebView so the
+        // (now focused, and therefore active) page is torn down deterministically instead of
+        // leaking and racing the activity teardown on the WebKit main loop.
+        if (webView != null) {
+            webView.destroy();
+            webView = null;
+        }
+        super.onDestroy();
+    }
+
     public WebView getWebView() { return webView; }
 }

wpeview/src/main/cpp/capi/WebKitWebView.cpp

@@ -397,9 +397,22 @@ void JNIWebKitWebViewCache::nativeEvaluateJavascript(
 void JNIWebKitWebViewCache::nativeScriptDialogConfirm(JNIEnv*, jobject, jlong dialogPtr, jboolean confirm, jstring text)
 {
     auto* dialog = reinterpret_cast<WebKitScriptDialog*>(dialogPtr); // NOLINT(performance-no-int-to-ptr)
-    if (webkit_script_dialog_get_dialog_type(dialog) == WEBKIT_SCRIPT_DIALOG_PROMPT && text != nullptr)
-        webkit_script_dialog_prompt_set_text(dialog, JNI::String(text).getContent().get());
-    webkit_script_dialog_confirm_set_confirmed(dialog, static_cast<gboolean>(confirm));
+    // Each dialog type accepts only its own result setter; calling the wrong one trips a
+    // g_return_if_fail in WebKit. Alerts carry no result and are answered purely by closing.
+    switch (webkit_script_dialog_get_dialog_type(dialog)) {
+    case WEBKIT_SCRIPT_DIALOG_CONFIRM:
+    case WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM:
+        webkit_script_dialog_confirm_set_confirmed(dialog, static_cast<gboolean>(confirm));
+        break;
+    case WEBKIT_SCRIPT_DIALOG_PROMPT:
+        // A confirmed prompt returns the entered text; a cancelled prompt leaves the text
+        // unset so JavaScript prompt() yields null.
+        if (confirm && text != nullptr)
+            webkit_script_dialog_prompt_set_text(dialog, JNI::String(text).getContent().get());
+        break;
+    case WEBKIT_SCRIPT_DIALOG_ALERT:
+        break;
+    }
 }
 
 void JNIWebKitWebViewCache::nativeScriptDialogClose(JNIEnv*, jobject, jlong dialogPtr)

wpeview/src/main/java/org/wpewebkit/wpeview/WebView.java

@@ -218,6 +218,9 @@ public void destroy() {
             webKitWebView.destroy();
             webKitWebView = null;
         }
+        // webKitWebView.destroy() invalidates the underlying native WPEView, so drop our reference
+        // too: any later widget callback (e.g. onFocusChanged during teardown) must not touch it.
+        platformView = null;
         if (ownsContext && wpeContext != null) {
             wpeContext.destroy();
             wpeContext = null;