Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] IgcCombo localization should be made possible in the same way as IgcGrid. #1527

Open
norikois opened this issue Dec 26, 2024 · 0 comments
Labels
feature-request 🆕 status: new The issue is new and will be reviewed when somebody picks it up.

Comments

@norikois
Copy link

Which component(s) are affected?

Combo

Description

It would be good if IgcCombo can be localized in a similar way to IgcGrid.

For example, currently, if you want to localize the following texts,
image
image

you need to write a code like this:

const combo = document.querySelector('igc-combo');
combo.placeholderSearch = "検索";
render(html`<span slot="empty">このリストは空です</span>`, combo);

On the other hand, in case of IgcGrid, you can make it just by preparing resource strings and set them to IgcGrid's resourceStrings:

const GridResourceStrings = {
  igx_grid_groupByArea_message: "列ヘッダーをここへドラッグして列をグループ化します。",
  igx_grid_emptyFilteredGrid_message: "レコードは見つかりませんでした。",
  igx_grid_emptyGrid_message: "グリッドにデータがありません。",
  igx_grid_filter: "フィルター",
  ...
}

const grid = document.querySelector("#grid1") as IgcGridComponent;
grid.resourceStrings = GridResourceStrings;

Reproduction

See the description above.

Workaround

See the description above.

Is this a regression?

No or unsure. This never worker, or I haven't tried before.

Affected versions

5.1.0

Browser/OS/Node environment

No dependency.

@norikois norikois added 🆕 status: new The issue is new and will be reviewed when somebody picks it up. bug Something isn't working labels Dec 26, 2024
@rkaraivanov rkaraivanov added feature-request and removed bug Something isn't working labels Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request 🆕 status: new The issue is new and will be reviewed when somebody picks it up.
Projects
None yet
Development

No branches or pull requests

2 participants