Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using Werror and Wall #74

Open
dpryan79 opened this issue Nov 20, 2022 · 0 comments
Open

Stop using Werror and Wall #74

dpryan79 opened this issue Nov 20, 2022 · 0 comments

Comments

@dpryan79
Copy link

Paragraph is currently not compilable because both it and the vendored graph-tools use -Werror -Wall. Patching the main paragraph CMakeLists.txt still yields:

2022-11-20T17:33:07.3654873Z 17:33:07 BIOCONDA INFO (OUT) /opt/conda/conda-bld/paragraph_1668965108268/work/build/external/graphtools-src/src/graphalign/GaplessAligner.cpp: In function 'std::__cxx11::list<graphtools::GraphAlignment> graphtools::getBestAlignmentToShortPath(const graphtools::Path&, int32_t, const string&)':
2022-11-20T17:33:07.3656847Z 17:33:07 BIOCONDA INFO (OUT) /opt/conda/conda-bld/paragraph_1668965108268/work/build/external/graphtools-src/src/graphalign/GaplessAligner.cpp:64:32: error: type qualifiers ignored on cast result type [-Werror=ignored-qualifiers]
2022-11-20T17:33:07.3658286Z 17:33:07 BIOCONDA INFO (OUT)    64 |     const auto end_extension = static_cast<const int32_t>(query.length() - start_pos - path.length());
2022-11-20T17:33:07.3659076Z 17:33:07 BIOCONDA INFO (OUT)       |                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2022-11-20T17:33:07.8570655Z 17:33:07 BIOCONDA INFO (OUT) cc1plus: all warnings being treated as errors
2022-11-20T17:33:07.8646032Z 17:33:07 BIOCONDA INFO (OUT) make[2]: *** [external/graphtools-build/CMakeFiles/graphtools.dir/build.make:76: external/graphtools-build/CMakeFiles/graphtools.dir/src/graphalign/GaplessAligner.cpp.o] Error 1

That's since the vendored graph-tools also has this. Please just remove these, you can't possibly hope to keep up with every compiler out there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant