Skip to content

Commit 723052b

Browse files
chore: drop Algebra.TensorProduct.rightAlgebra' (#184)
1 parent 94b750a commit 723052b

File tree

2 files changed

+4
-20
lines changed

2 files changed

+4
-20
lines changed

FLT/AutomorphicForm/QuaternionAlgebra.lean

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ noncomputable abbrev incl₁ : Dˣ →* Dfx F D :=
3333
Units.map Algebra.TensorProduct.includeLeftRingHom.toMonoidHom
3434

3535
noncomputable abbrev incl₂ : (FiniteAdeleRing (𝓞 F) F)ˣ →* Dfx F D :=
36-
Units.map Algebra.TensorProduct.rightAlgebra'.toMonoidHom
36+
Units.map Algebra.TensorProduct.rightAlgebra.toMonoidHom
3737

3838
/-!
3939
This definition is made in mathlib-generality but is *not* the definition of an automorphic

FLT/DivisionAlgebra/Finiteness.lean

+3-19
Original file line numberDiff line numberDiff line change
@@ -33,32 +33,16 @@ section missing_instances
3333

3434
variable {R D A : Type*} [CommSemiring R] [Semiring D] [CommSemiring A] [Algebra R D] [Algebra R A]
3535

36-
-- Algebra.TensorProduct.rightAlgebra has unnecessary commutativity assumptions
37-
-- This should be fixed in mathlib; ideally it should be an exact mirror of leftAlgebra but
38-
-- I ignore S as I don't need it.
39-
def Algebra.TensorProduct.rightAlgebra' : Algebra A (D ⊗[R] A) :=
40-
Algebra.TensorProduct.includeRight.toRingHom.toAlgebra' (by
41-
simp only [AlgHom.toRingHom_eq_coe, RingHom.coe_coe, Algebra.TensorProduct.includeRight_apply]
42-
intro a b
43-
apply TensorProduct.induction_on (motive := fun b ↦ 1 ⊗ₜ[R] a * b = b * 1 ⊗ₜ[R] a)
44-
· simp only [mul_zero, zero_mul]
45-
· intro d a'
46-
simp only [Algebra.TensorProduct.tmul_mul_tmul, one_mul, mul_one,
47-
NonUnitalCommSemiring.mul_comm]
48-
· intro x y hx hy
49-
rw [left_distrib, hx, hy, right_distrib]
50-
)
51-
5236
-- this makes a diamond for Algebra A (A ⊗[R] A) which will never happen here
53-
attribute [local instance] Algebra.TensorProduct.rightAlgebra'
37+
attribute [local instance] Algebra.TensorProduct.rightAlgebra
5438

5539
-- These seem to be missing
5640
instance [Module.Finite R D] : Module.Finite A (D ⊗[R] A) := sorry
5741
instance [Module.Free R D] : Module.Free A (D ⊗[R] A) := sorry
5842

5943
end missing_instances
6044

61-
attribute [local instance] Algebra.TensorProduct.rightAlgebra'
45+
attribute [local instance] Algebra.TensorProduct.rightAlgebra
6246

6347
variable (K : Type*) [Field K] [NumberField K]
6448
variable (D : Type*) [DivisionRing D] [Algebra K D]
@@ -81,7 +65,7 @@ noncomputable abbrev incl₁ : Dˣ →* Dfx K D :=
8165
Units.map Algebra.TensorProduct.includeLeftRingHom.toMonoidHom
8266

8367
noncomputable abbrev incl₂ : (FiniteAdeleRing (𝓞 K) K)ˣ →* Dfx K D :=
84-
Units.map Algebra.TensorProduct.rightAlgebra'.toMonoidHom
68+
Units.map Algebra.TensorProduct.rightAlgebra.toMonoidHom
8569

8670
-- Voight "Main theorem 27.6.14(b) (Fujisaki's lemma)"
8771
/-!

0 commit comments

Comments
 (0)