Skip to content

PHP 8: CSV Export: issue with numeric + CR/line feed #514

@Gary-van-Breda

Description

@Gary-van-Breda

A change has occurred in PHP 8: is_numeric now returns true for any whitespace after the number. This means that the following now returns TRUE from is_numeric, where previously it returned false:
"10
"

This in turn means the logic in function get_csv in file modules/indicia_svc_data/controllers/data_service_base.php is no longer valid: the string above will no longer be wrapped in quotes, breaking the record over 2 lines.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions