fix: improve user agent parsing and handle null values in email tracking

Author: inikoo

app/Actions/Comms/EmailTrackingEvent/PostProcessingEmailTrackingEvent.php

@@ -22,15 +22,19 @@ class PostProcessingEmailTrackingEvent extends OrgAction
 
     public function handle(EmailTrackingEvent $emailTrackingEvent): EmailTrackingEvent
     {
-        $parsedUserAgent = (new Browser())->parse(Arr::get($emailTrackingEvent->data, 'userAgent'));
+        $ip        = Arr::get($emailTrackingEvent->data, 'ipAddress');
+        $userAgent = Arr::get($emailTrackingEvent->data, 'userAgent');
 
-        $ip = Arr::get($emailTrackingEvent->data, 'ipAddress');
-        $device = $parsedUserAgent->deviceType();
+        $device = null;
+        if ($userAgent) {
+            $parsedUserAgent = (new Browser())->parse($userAgent);
+            $device          = $parsedUserAgent->deviceType();
+        }
 
         return $this->update($emailTrackingEvent, [
-            'ip' => $ip,
+            'ip'     => $ip,
             'device' => $device,
-            'data' => (object) []
-       ]);
+            'data'   => (object)[]
+        ]);
     }
 }

app/Actions/Comms/SesNotification/ProcessSesNotification.php

@@ -172,12 +172,7 @@ public function asCommand(Command $command): int
         }
         $command->line('Number ses notifications to process '.SesNotification::count());
 
-        foreach (SesNotification::all() as $sesNotification) {
-            $pending = $this->handle($sesNotification);
-            if ($pending) {
-                // print_r($pending);
-            }
-        }
+
 
         return 0;
     }