Fix: Gracefully handle cache drivers that do not support tagging (#75)

* fix: gracefully handle cache drivers that do not support tagging

The default config enables cache tags, but drivers like "file" or
"database" do not support tagging. This change:

- Types the Cache constructor $tags parameter as array and normalises
  the config value in GeoIP so null/missing values become an empty array
- Replaces the hardcoded driver list in Clear command with a dynamic
  supportsTags() check that covers all current and future drivers
- Updates config comment to explain auto-fallback behaviour
- Adds a test covering tagged-cache construction on a non-tagging driver

Addresses the same issue as Torann#255.

* address review feedback: improve test, add logging, clarify error message

- Fix test to use file cache driver (which genuinely lacks tag support)
  instead of array driver, so the fallback path is actually exercised
- Log a warning in GeoIP constructor when cache tags are configured but
  the active driver does not support tagging
- Improve geoip:clear error message to explain why selective clearing
  is unavailable

* ci: drop PHP 8.2 from test matrix

composer.json already requires ^8.3, so 8.2 builds are unnecessary.

* ci: run php-cs-fixer from composer instead of Docker image

The Docker image (oskarstark/php-cs-fixer-ga) does not have access to
the project's composer dependencies, causing a fatal error because the
custom IxDFCodingStandard\PhpCsFixer\Config class is not found. Use the
locally installed php-cs-fixer from vendor/bin instead.

* ci: improve code style workflow with fork safety and Rector

- Replace Docker-based php-cs-fixer with composer scripts
- Add Rector auto-fix step alongside php-cs-fixer
- Add fork-safe dual-job setup: auto-fix for internal PRs, dry-run
  check for fork PRs
- Add rector:dry and cs:check composer scripts for CI dry-run jobs

* style: auto-fix (rector + php-cs-fixer)

* ci: run code style workflow on PHP 8.3 (minimum supported version)

* chore: demote cache tag fallback log to info level

---------

Co-authored-by: GitHub Actions <actions@github.com>

Author: alies-dev

.github/workflows/php-coding-style.yml

@@ -1,49 +1,71 @@
-name: Coding style
+name: Code Style
 
 on:
-  pull_request:
+  push:
+    branches: [main]
     paths:
       - '**.php'
-      - '.composer.json'
-      - '.php_cs'
-      - '.github/workflows/php-coding-style.yml'
-  push:
+      - 'composer.json'
+  pull_request:
     paths:
       - '**.php'
-      - '.composer.json'
-      - '.php_cs'
-      - '.github/workflows/php-coding-style.yml'
-    branches-ignore:
-      - main # protected
+      - 'composer.json'
 
 jobs:
-  style:
+  fix:
+    name: Auto-fix code style
+    # Skip fork PRs — GITHUB_TOKEN can't push to external forks.
+    # Fork contributors: run `composer rector && composer cs` locally.
+    if: github.event_name == 'push' || github.event.pull_request.head.repo.full_name == github.repository
     runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v6
+        with:
+          ref: ${{ github.head_ref }}
+          token: ${{ github.token }}
+
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: 8.3
+          coverage: none
+
+      - name: Install composer dependencies
+        run: composer install --prefer-dist --no-progress --no-interaction
+
+      - name: Rector
+        run: composer rector
 
+      - name: PHP CS Fixer
+        run: composer cs
+
+      - name: Commit fixes
+        uses: stefanzweifel/git-auto-commit-action@v7
+        with:
+          commit_message: 'style: auto-fix (rector + php-cs-fixer)'
+          commit_author: 'GitHub Actions <actions@github.com>'
+
+  check:
+    name: Verify code style (forks)
+    # Only run the check job on fork PRs where we can't auto-fix.
+    if: github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name != github.repository
+    runs-on: ubuntu-latest
     steps:
-      -   name: Checkout code
-          uses: actions/checkout@v6
-
-      -   name: Setup PHP
-          uses: shivammathur/setup-php@v2
-          with:
-            php-version: 8.4
-            coverage: none
-          env:
-            COMPOSER_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-
-      -   name: Install composer dependencies
-          run: composer install --no-interaction --no-progress --no-scripts
-
-      -   name: Lint facade docblocks
-          run: php -f vendor/bin/facade.php InteractionDesignFoundation\\GeoIP\\Facades\\GeoIP
-
-      -   name: Fix style
-          uses: docker://oskarstark/php-cs-fixer-ga
-          with:
-            args: --config=.php-cs-fixer.php --allow-risky=yes
-
-      -   name: Commit changes
-          uses: stefanzweifel/git-auto-commit-action@v7
-          with:
-            commit_message: Fix coding style
+      - name: Checkout code
+        uses: actions/checkout@v6
+
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: 8.3
+          coverage: none
+
+      - name: Install composer dependencies
+        run: composer install --prefer-dist --no-progress --no-interaction
+
+      - name: Rector (dry-run)
+        run: composer rector:dry
+
+      - name: PHP CS check
+        run: composer cs:check

.github/workflows/run-tests.yml

@@ -12,12 +12,9 @@ jobs:
     strategy:
       fail-fast: true
       matrix:
-        php: [8.5, 8.4, 8.3, 8.2]
+        php: [8.5, 8.4, 8.3]
         laravel: [^12.0, ^13.0]
         dependencies: [lowest, highest]
-        exclude:
-          - laravel: ^13.0
-            php: 8.2
 
     name: P${{ matrix.php }} | L${{ matrix.laravel }} | ${{ matrix.dependencies == 'highest' && '↑' || '↓' }}
 

composer.json

@@ -78,6 +78,8 @@
         "phpstan": "vendor/bin/phpstan --level=0 --no-progress analyse --configuration phpstan.neon --memory-limit 2G",
         "psalm": "vendor/bin/psalm",
         "rector": "vendor/bin/rector process --config rector.php ",
+        "rector:dry": "vendor/bin/rector process --config rector.php --dry-run",
+        "cs:check": "@php -d memory_limit=-1 vendor/bin/php-cs-fixer fix --no-interaction --ansi --verbose --dry-run",
         "sa": "@psalm",
         "sa:bl": "@psalm --set-baseline=psalm-baseline.xml",
         "test": "vendor/bin/phpunit"

config/geoip.php

@@ -128,8 +128,10 @@
     | Cache Tags
     |--------------------------------------------------------------------------
     |
-    | Cache tags are not supported when using the file or database cache
-    | drivers in Laravel. This is done so that only locations can be cleared.
+    | Cache tags allow you to selectively clear only GeoIP cached locations
+    | without affecting other cached data. If the active cache driver does
+    | not support tagging (e.g. file, database), tags are automatically
+    | ignored at runtime. Set to null or an empty array to disable tagging.
     |
     */
 

psalm-baseline.xml

@@ -71,7 +71,6 @@
     <MixedArgument>
       <code><![CDATA[$config]]></code>
       <code><![CDATA[$this->config('cache_expires', 30)]]></code>
-      <code><![CDATA[$this->config('cache_tags')]]></code>
       <code><![CDATA[$this->config('default_location', [])]]></code>
     </MixedArgument>
     <MixedArgumentTypeCoercion>

src/Cache.php

@@ -24,11 +24,9 @@ final class Cache
     /**
      * Create a new cache instance.
      *
-     * @param CacheManager $cache
-     * @param array $tags
-     * @param int $expires
+     * @param list<string> $tags
      */
-    public function __construct(CacheManager $cache, $tags, private readonly int $expires = 30)
+    public function __construct(CacheManager $cache, array $tags, private readonly int $expires = 30)
     {
         $this->cache = ($tags === [] || !$cache->supportsTags()) ? $cache : $cache->tags($tags);
     }

src/Console/Clear.php

@@ -24,7 +24,10 @@ class Clear extends Command
     public function handle(): int
     {
         if ($this->isSupported() === false) {
-            $this->output->error('Default cache system does not support tags');
+            $this->output->error(
+                'Cannot selectively clear GeoIP cache: either cache tags are not configured'
+                .' or the active cache driver does not support tagging.'
+            );
             return self::FAILURE;
         }
 
@@ -40,8 +43,8 @@ public function handle(): int
      */
     protected function isSupported(): bool
     {
-        return (empty(app('geoip')->config('cache_tags')) === false)
-            && (in_array(config('cache.default'), ['file', 'database'], true) === false);
+        return !empty(app('geoip')->config('cache_tags'))
+            && app(\Illuminate\Cache\CacheManager::class)->supportsTags();
     }
 
     /**

src/GeoIP.php

@@ -64,9 +64,15 @@ public function __construct(
         private readonly LoggerInterface $logger,
     ) {
         // Create caching instance
+        /** @var list<string> $cacheTags */
+        $cacheTags = array_values((array) $this->config('cache_tags', []));
+        if ($cacheTags !== [] && !$cache->supportsTags()) {
+            $this->logger->info('GeoIP: cache tags are configured but the active cache driver does not support tagging. Tags will be ignored.');
+        }
+
         $this->cache = new Cache(
             $cache,
-            $this->config('cache_tags'),
+            $cacheTags,
             $this->config('cache_expires', 30)
         );
         $this->cache->setPrefix((string) $this->config('cache_prefix'));

tests/CacheTest.php

@@ -32,6 +32,32 @@ public function should_return_valid_location(): void
         $this->assertFalse($uncachedLocation->default);
     }
 
+    #[Test]
+    public function should_fall_back_to_untagged_cache_when_driver_does_not_support_tags(): void
+    {
+        // Switch to file driver which does not support tagging
+        config(['cache.default' => 'file']);
+        $cacheManager = app(CacheManager::class);
+
+        $this->assertFalse($cacheManager->supportsTags(), 'File cache driver should not support tags');
+
+        // Tags are configured, but driver doesn't support them — should not throw
+        $cache = new Cache($cacheManager, ['some-tag'], 30);
+
+        $location = new Location([
+            'ip' => '81.2.69.142',
+            'iso_code' => 'US',
+            'lat' => 41.31,
+            'lon' => -72.92,
+        ]);
+
+        $cache->set($location['ip'], $location);
+        $cachedLocation = $cache->get($location['ip']);
+
+        $this->assertInstanceOf(Location::class, $cachedLocation);
+        $this->assertSame('81.2.69.142', $cachedLocation->ip);
+    }
+
     #[Test]
     public function it_flushes_empty_cache(): void
     {