Add more test cases

Author: carlostome

eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/RatifySpec.hs

@@ -198,7 +198,7 @@ spoAndCCVotingSpec = do
         else do
           getLastEnactedParameterChange `shouldReturn` SNothing
           newRefScriptBaseFee `shouldBe` initialRefScriptBaseFee
-    fspecify "Constitution cannot be changed if active committee size is below min size"
+    it "Constitution cannot be changed if active committee size is below min size"
       . whenPostBootstrap
       $ do
         modifyPParams $ \pp ->
@@ -241,9 +241,28 @@ spoAndCCVotingSpec = do
         getConstitution `shouldNotReturn` newConstitution
     -- https://github.com/IntersectMBO/cardano-ledger/issues/5418
     -- TODO: Re-enable after issue is resolved, by removing this override
-    disableInConformanceIt
-      "Constitution cannot be changed if an active committee doesn't vote even if the committee threshold is 0" $
-      whenPostBootstrap $ do
+    xit
+      "Constitution cannot be changed if an active committee without hot credentials registered doesn't vote even if the committee threshold is 0"
+      $ whenPostBootstrap
+      $ do
+        modifyPParams $ \pp ->
+          pp
+            & ppCommitteeMinSizeL .~ 2
+        modifyCommittee $ fmap (committeeThresholdL .~ 0 %! 1)
+        (drep, _, _) <- setupSingleDRep 1_000_000_000
+        SJust committee <- getCommittee
+        committeeThreshold committee `shouldBe` 0 %! 1
+        Map.size (committeeMembers committee) `shouldBe` 2
+        forM_ (Map.keys $ committeeMembers committee) ccShouldNotBeExpired
+        (proposal, newConstitution) <- mkConstitutionProposal SNothing
+        gaiConstitution <- submitProposal proposal
+        submitYesVote_ (DRepVoter drep) gaiConstitution
+        passNEpochs 2
+        getConstitution `shouldReturn` newConstitution
+    it
+      "Constitution can be changed if an active committee with hot credentials registered doesn't vote when the committee threshold is 0"
+      $ whenPostBootstrap
+      $ do
         modifyPParams $ \pp ->
           pp
             & ppCommitteeMinSizeL .~ 2
@@ -253,12 +272,37 @@ spoAndCCVotingSpec = do
         committeeThreshold committee `shouldBe` 0 %! 1
         Map.size (committeeMembers committee) `shouldBe` 2
         forM_ (Map.keys $ committeeMembers committee) ccShouldNotBeExpired
-        oldConstitution <- getConstitution
-        (proposal, _) <- mkConstitutionProposal SNothing
+        (proposal, newConstitution) <- mkConstitutionProposal SNothing
         gaiConstitution <- submitProposal proposal
         submitYesVote_ (DRepVoter drep) gaiConstitution
+        mapM_ registerCommitteeHotKey (Map.keys $ committeeMembers committee)
         passNEpochs 2
-        getConstitution `shouldReturn` oldConstitution
+        getConstitution `shouldReturn` newConstitution
+    it
+      "Constitution can be changed regardless of active committee votes when the committee threshold is 0"
+      $ whenPostBootstrap
+      $ do
+        modifyPParams $ \pp ->
+          pp
+            & ppCommitteeMinSizeL .~ 2
+        modifyCommittee $ fmap (committeeThresholdL .~ 0 %! 1)
+        (drep, _, _) <- setupSingleDRep 1_000_000_000
+        SJust committee <- getCommittee
+        committeeThreshold committee `shouldBe` 0 %! 1
+        Map.size (committeeMembers committee) `shouldBe` 2
+        forM_ (Map.keys $ committeeMembers committee) ccShouldNotBeExpired
+        (proposal, newConstitution) <- mkConstitutionProposal SNothing
+        gaiConstitution <- submitProposal proposal
+        submitYesVote_ (DRepVoter drep) gaiConstitution
+        hotKeys <- mapM registerCommitteeHotKey (Map.keys $ committeeMembers committee)
+        forM_ hotKeys $ \c ->
+          oneof
+            [ return ()
+            , submitYesVote_ (CommitteeVoter c) gaiConstitution
+            , submitVote_ VoteNo (CommitteeVoter c) gaiConstitution
+            ]
+        passNEpochs 2
+        getConstitution `shouldReturn` newConstitution
     it "Constitution cannot be changed if min committee size is 0 and committee threshold is not 0"
       . whenPostBootstrap
       $ do