Skip to content

Conversation

@Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Nov 18, 2025

Description

This PR adds a bunch of CBOR golden tests. There are two kinds of new tests in this PR:

I also added forEachEraVersion that runs tests with each valid protocol version in that era.

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use scripts/gen-cddl.sh)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@Soupstraw Soupstraw force-pushed the jj/cbor-golden-tests branch 2 times, most recently from 096540b to b840866 Compare November 19, 2025 13:42
@Soupstraw Soupstraw marked this pull request as ready for review November 19, 2025 13:42
@Soupstraw Soupstraw requested a review from a team as a code owner November 19, 2025 13:42
@Soupstraw Soupstraw force-pushed the jj/cbor-golden-tests branch 3 times, most recently from a47ac70 to b3aeb3b Compare November 19, 2025 14:10
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the direction where we are going with these golden tests!!!
Thank you for doing this work.

@Soupstraw Soupstraw force-pushed the jj/cbor-golden-tests branch 5 times, most recently from f583a3d to 9de7817 Compare November 25, 2025 11:54
@Soupstraw Soupstraw requested a review from lehins November 25, 2025 11:54
@Soupstraw Soupstraw force-pushed the jj/cbor-golden-tests branch 2 times, most recently from 5c4aa3b to 38c6db3 Compare November 25, 2025 16:24
@Soupstraw Soupstraw marked this pull request as draft November 26, 2025 16:19
@Soupstraw Soupstraw force-pushed the jj/cbor-golden-tests branch from f9a82db to 2516532 Compare November 27, 2025 11:26
@Soupstraw Soupstraw marked this pull request as ready for review November 27, 2025 11:28
@Soupstraw Soupstraw force-pushed the jj/cbor-golden-tests branch 3 times, most recently from fd62ee2 to 96d2e23 Compare December 4, 2025 10:46
@Soupstraw Soupstraw force-pushed the jj/cbor-golden-tests branch from ccb9df4 to 7aea170 Compare December 5, 2025 11:22
@Soupstraw Soupstraw enabled auto-merge (rebase) December 5, 2025 11:24
@Soupstraw Soupstraw force-pushed the jj/cbor-golden-tests branch from 7aea170 to 56af304 Compare December 5, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add positive duplicateCertsTx tests to Shelley and Conway

3 participants