Skip to content

Conversation

@aniketd
Copy link
Contributor

@aniketd aniketd commented Nov 26, 2025

Description

New library named cddl for Conway to implement typeclass-based cuddle definitions to generate .cddl files from.

Follow-up PRs should implement for Dijkstra.

This is the second phase in our efforts to address #5194

NOTE

codegen on CI is expected to FAIL, and its diff is important to know exactly what has changed in the new implementation.

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use scripts/gen-cddl.sh)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@aniketd aniketd changed the title CDDL with typeclasses: conway [merge 5443 first] CDDL with typeclasses: conway Dec 2, 2025
@aniketd aniketd force-pushed the aniketd/cddl-typeclass-conway branch from c309e0d to 4dc6ece Compare December 2, 2025 15:57
@aniketd aniketd marked this pull request as ready for review December 2, 2025 16:02
@aniketd aniketd requested a review from a team as a code owner December 2, 2025 16:02
@aniketd aniketd force-pushed the aniketd/cddl-typeclass-conway branch 4 times, most recently from cb5c06e to 1bd7a1a Compare December 4, 2025 08:56
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome!!!
Please remove changes to actual CDDL files, since it results in CI failure and breaks master: https://github.com/IntersectMBO/cardano-ledger/actions/runs/19923202590/job/57119367102?pr=5456

We had to undo changes that were introduced in previous PRs: #5445 and #5462

Don't get me wrong, I am glad you did include these changes to generated files in this PR for the purpose of review, since it gives more confidence that changes to huddle spec do not affect the correctness of CDDL generation. But, we should revert them and only apply them once we are ready to switch to this class based approach on permanent basis.

@aniketd aniketd force-pushed the aniketd/cddl-typeclass-conway branch 2 times, most recently from d843712 to 8f94e5c Compare December 5, 2025 14:58
@aniketd aniketd force-pushed the aniketd/cddl-typeclass-conway branch from 8f94e5c to 56a3d63 Compare December 8, 2025 12:49
@aniketd aniketd enabled auto-merge (rebase) December 8, 2025 14:47
@aniketd aniketd merged commit fbab167 into master Dec 8, 2025
118 of 121 checks passed
@aniketd aniketd deleted the aniketd/cddl-typeclass-conway branch December 8, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants