-
Notifications
You must be signed in to change notification settings - Fork 170
CDDL with typeclasses: conway #5456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c309e0d to
4dc6ece
Compare
cb5c06e to
1bd7a1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome!!!
Please remove changes to actual CDDL files, since it results in CI failure and breaks master: https://github.com/IntersectMBO/cardano-ledger/actions/runs/19923202590/job/57119367102?pr=5456
We had to undo changes that were introduced in previous PRs: #5445 and #5462
Don't get me wrong, I am glad you did include these changes to generated files in this PR for the purpose of review, since it gives more confidence that changes to huddle spec do not affect the correctness of CDDL generation. But, we should revert them and only apply them once we are ready to switch to this class based approach on permanent basis.
d843712 to
8f94e5c
Compare
Repeat the same additions as core, shelley, allegra, mary, alonzo, babbage.
Remove unused maybeTaggedOSet
8f94e5c to
56a3d63
Compare
Description
New library named
cddlfor Conway to implement typeclass-based cuddle definitions to generate .cddl files from.Follow-up PRs should implement for Dijkstra.
This is the second phase in our efforts to address #5194
NOTE
codegenon CI is expected to FAIL, and its diff is important to know exactly what has changed in the new implementation.Checklist
Tests added or updated when needed.CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
Versions updated in.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
Version bounds in.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).