Swap Mempool/Ledger predicate failures in Dijkstra #5461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@lehins this is just a draft because it doesn't build yet: I am not sure how I should convince GHC to accept my constraints on test code:
I suppose the issue is that the Imp tests for next eras call the ones for the previous era, so probably there is an easy way to rearrange this to have it not complain, but I am not seeing it atm. |
lehins
reviewed
Dec 2, 2025
eras/dijkstra/impl/src/Cardano/Ledger/Dijkstra/Rules/Mempool.hs
Outdated
Show resolved
Hide resolved
10 tasks
f-f
force-pushed
the
f-f/5447
branch
3 times, most recently
from
07b468a to
b80b176
Compare
f-f
commented
Dec 5, 2025
|
|
||
| describe "Mempool" $ do | ||
| let | ||
| submitFailingMempoolTx :: |
Collaborator
Author
There was a problem hiding this comment.
these type signatures are needed to make the compiler infer correctly the injectFailure below
f-f
commented
Dec 5, 2025
| exampleTxDijkstra | ||
| exampleDijkstraGenesis | ||
|
|
||
| mkLedgerExamples :: |
Collaborator
Author
There was a problem hiding this comment.
We do need a new copy of this one unfortunately, because of the wrapping of the Ledger failure into the Mempool failure
To get there we need to move the `ApplyTxError era` type to be a data family in the ApplyTx class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #5447, fix #5448
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).