PlutusV3: Renamed fromGHC to fromHaskellRatio #5463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
requested changes
Dec 3, 2025
Collaborator
lehins
left a comment
lehins
left a comment
There was a problem hiding this comment.
Beside the comment about the lower bound we also need to update index-state for CHaP and nix flake in order to bring in the new version of plutus
|
|
||
| transBoundedRational :: BoundedRational r => r -> PV3.Rational | ||
| transBoundedRational = PV3.fromGHC . unboundRational | ||
| transBoundedRational = PV3.fromHaskellRatio . unboundRational |
Collaborator
There was a problem hiding this comment.
@bezirg, which version of plutus-ledger-api started exporting fromHaskellRatio? We need to add a lower bound in the cabal file on that version in order to make sure cabal doesn't try to build an incompatible version.
Collaborator
Author
There was a problem hiding this comment.
It should be plutus 1.56.0.0 which is not released yet. @Unisay is on it to release it with the way you proposed in ChaP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).