Skip to content

Conversation

@carlostome
Copy link
Contributor

@carlostome carlostome commented Dec 5, 2025

Description

  • Move test "Committee proposals pass" to its proper place
  • Add tests covering the following cases:
    • When CC threshold is 0:
      1. Non expired committee without hot credentials
      2. Active committee not voting
      3. Active committee voting whatever
      4. Min committee size = 0
    • When CC threshold is not 0:
      1. Min committee size = 0

Related to #5418

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use scripts/gen-cddl.sh)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@carlostome carlostome requested a review from a team as a code owner December 5, 2025 12:38
@carlostome carlostome marked this pull request as draft December 5, 2025 13:06
@carlostome carlostome force-pushed the carlos/add-conf-test branch 6 times, most recently from 9ac443a to 5ee671e Compare December 6, 2025 07:33
@carlostome carlostome changed the title Add Imp tests for the case of committee threshold = 0 Add Imp tests to cover more cases of active/inactive committee Dec 6, 2025
@carlostome carlostome force-pushed the carlos/add-conf-test branch from 5ee671e to 1d82e40 Compare December 6, 2025 07:42
@carlostome carlostome marked this pull request as ready for review December 6, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants