Add optional previous epoch Nonce to BHeaderView #5467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agustinmista
force-pushed
the
peras/optional-nonce-in-bheaderview
branch
2 times, most recently
from
ea601b6 to
eb44793
Compare
This commit add an optional Nonce to BHeaderView to carry the previous epoch nonce needed to validate Peras certificates embedded in blocks. Additionally, it tweaks 'makeHeaderView' to be able to pass this nonce from the consensus side.
This commit adds a check in the Dijkstra BBODY transition rule to enforce having a non-null previous epoch nonce so that Peras certificates can be validated should they appear in a block body.
agustinmista
force-pushed
the
peras/optional-nonce-in-bheaderview
branch
from
eb44793 to
9188e90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses #5437 by:
BHeaderViewrecord,makeHeaderViewso that this optional nonce can be passed from the consensus side (not super sure if this is the right place to tweak the Ledger <-> Consensus API),dijkstraBbodyTransitionrule (not super sure about this either, see note below).NOTE: I'm not sure if the second commit actually helps by enforcing that the nonce will be present later on, or if we instead want to defer this check until we actually want to use the nonce for certificate validation once these start popping up in blocks.
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).