Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should handle forks gracefully #293

Open
JAForbes opened this issue Mar 27, 2022 · 0 comments
Open

Should handle forks gracefully #293

JAForbes opened this issue Mar 27, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@JAForbes
Copy link
Owner

When forking a package, you may want to still publish to npm for the fork, but without editing package.json as you expect to upstream your changes eventually.

pr-release should probably default to ignoring the package.json name when publishing from a fork, and instead use the github repo path e.g. JAForbes/pr-release becomes jaforbes-pr-release.

I think this behaviour should be opt out instead of opt in because we're trying to avoid changes to source in the fork that are unrelated to legit enchancements or bug fixes.

Maybe the opt out can occur via env variable, or maybe just a flag like --no-forks to opt out.

Need to think about that one.

@JAForbes JAForbes added the enhancement New feature or request label Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants
@JAForbes and others