Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make release channels first class #361

Open
JAForbes opened this issue Nov 16, 2024 · 1 comment
Open

Make release channels first class #361

JAForbes opened this issue Nov 16, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@JAForbes
Copy link
Owner

I no longer think pr-release should need to be configured once per release channel, a single piece of config with some patterns/semver ranges should be able to handle n channels.

I'd never considered this before because I don't tend to juggle a large number of release channels, but thinking of e.g. React, they are up to v19 and still do security support for v15+. It would be error prone and also a chore to need specific config for each supported release, it should just work based on a convention.

Mithril technically supports 3 channels currently (0.x, 1.x, 2.x), and soon to be 4 whenever v3 is released. Releases aren't super frequent but still, it'd be nice to know that config will hold when a new channel is required.

Also great for experiments, you could start release channels for prerelease tags. E.g. next: next-(?<major>v\d)\-?(?<prerelease>.*)?
could matchnext-v1, next-v2andnext-v3-hydration`. The pattern matching could be used for filtering semver tags. E.g. finding only tags that match that semver major and prerelease label. I'm using named regex syntax here but it could just be mustache or something else that is easier to write (especially in yml).

You could add minor in their too and have semver minor release channels. Which is more granular than I would ever want, but might make sense for some projects.

For simple projects we can still support the current config, if there's no patterns we just assume there's only 1 release channel.

@JAForbes JAForbes added the enhancement New feature or request label Nov 16, 2024
@JAForbes
Copy link
Owner Author

Thinking for now, all that is needed is a semver range arg just to fix #362, and maybe everything else can be covered with githubs existing interpolation support in actions yml files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant