Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carbon tracking vignette and permafrost c pool #699

Open
kdorheim opened this issue May 3, 2023 · 3 comments
Open

Carbon tracking vignette and permafrost c pool #699

kdorheim opened this issue May 3, 2023 · 3 comments

Comments

@kdorheim
Copy link
Contributor

kdorheim commented May 3, 2023

Looking at the carbon tracking vignette there is some unexpected behavior in the first figure, without the permafrost module activated wouldn't we expect the permafrost carbon pool to be 0?

@dawnlwoodard
Copy link
Contributor

what's the total amount of carbon in there? Like is it some miniscule amount or an actually substantial quantity? And does the ini file the run is using show 0 for the pool?

@kdorheim
Copy link
Contributor Author

kdorheim commented May 5, 2023

Ah! Good catch @dawnlwoodard! The total (sum of all source_name)permafrost_c is 0 over the entire run. So it is behaving as expected not a bug which is great news. Okay well may be in that case we should update the vignette with a note explaining this results/may be not include the permafrost_c pool in the plot?

@kdorheim kdorheim added documentation and removed bug labels May 5, 2023
@dawnlwoodard
Copy link
Contributor

Great! Glad it was that easy haha. But yes sounds like the vignette should probably be updated to not include that plot to avoid confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants