Fix saving listing changes in TUI

- The actual issue was that save_listing db method requires release_id
  which is not allowed to be empty in the db, even though actually the
  DB schema has been corrected.
- Get listing details from DB, rather than Discogs. Speeds up but was
  not the issue.
- Fix an issue where placeholder for price is a string. Remove
  placeholder entirely.
- Contains some useless passing of release_id - not sure where anymore.
  Screw it.

Author: JOJ0

discodos/ctrl/tui.py

@@ -94,10 +94,10 @@ def action_edit_sales_listing(self):
         """Open the edit screen for a sales listing."""
         row_key, _ = self.table.coordinate_to_cell_key(self.table.cursor_coordinate)
         listing_id = self.table.get_cell(row_key, "d_sales_listing_id")
-        listing, l_err, _ = self.fetch_sales_listing_details(listing_id, tui_view=True)
-        if l_err:
-            self.rlog.write(f"Error fetching sales listing details: {l_err}")
-            return
+        release_id = self.table.get_cell(row_key, "discogs_id")
+        listing = self.collection.get_sales_listing_details(listing_id)
+        if not listing:
+            self.rlog.write("Error getting sales listing from DiscoBASE.")
 
         def save_changes(**kwargs):
             if not self.collection.update_sales_listing(
@@ -113,6 +113,7 @@ def save_changes(**kwargs):
                 return
 
             listing["d_sales_listing_id"] = listing_id
+            listing["d_sales_release_id"] = release_id
             created = self.collection.create_sales_entry(listing)
             if not created:
                 self.rlog.write("Updating sales entry in DiscoBASE failed")
@@ -141,6 +142,7 @@ def save_changes(**kwargs):
             EditScreen(
                 save_changes,
                 listing_id=listing_id,
+                release_id=listing["d_sales_release_id"],
                 price=listing["d_sales_price"],
                 condition=listing["d_sales_condition"],
                 sleeve_condition=listing["d_sales_sleeve_condition"],

discodos/ctrl/tui_edit.py

@@ -17,6 +17,7 @@ def __init__(
         self,
         on_save,
         listing_id,
+        release_id,
         price,
         condition,
         sleeve_condition,
@@ -28,8 +29,9 @@ def __init__(
     ):
         super().__init__()
         self.caption = listing_id
+        self.release_id = release_id  # required for saving
         # Initialize text based fields with existing or default values
-        self.price = Input(value=price or "", placeholder="Price")
+        self.price = Input(str(price))
         self.location = Input(value=location or "", placeholder="Location")
         self.comments = Input(value=comments or "", placeholder="Public comments")
         self.comments_private = Input(value=comments_private or "",
@@ -94,6 +96,7 @@ def on_button_pressed(self, event):
             status = self.query_one("#status")
             allow_offers = self.query_one("#allow_offers")
             self.on_save(
+                release_id=self.release_id,
                 price=self.price.value,
                 condition=condition.pressed_button.name,
                 sleeve_condition=sleeve_condition.pressed_button.name,

discodos/model/discogs.py

@@ -398,6 +398,7 @@ def list_for_sale(  # pylint: disable=too-many-positional-arguments,too-many-arg
     def update_sales_listing(  # pylint: disable=too-many-positional-arguments,too-many-arguments
         self,
         listing_id=None,
+        release_id=None,
         condition=None,
         sleeve_condition=None,
         price=None,
@@ -422,7 +423,11 @@ def update_sales_listing(  # pylint: disable=too-many-positional-arguments,too-m
             listing.save()
             return True
         except Exception as Exc:
-            log.error("Exception while trying to update Marketplace listing: %s", Exc)
+            log.error(
+                "Exception while trying to update Marketplace listing for release %s: %s",
+                release_id,
+                Exc,
+            )
             return False
 
     def remove_sales_listing(self, listing_id):