-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linting for js and graphql #42
Comments
Perhaps we can work our way towards using some of the AirBnB's ESLint configs https://mikelow.dev/blog/how-to-keep-airbnb-eslint-config-in-typescript (there is a hooks extension as well). More detailed information can be found on https://airbnb.io/javascript/react/. I believe it can work well with TypeScript, even without using the recommended babel config. |
I'm not suggesting following the AirBnB configs blindly. If there is something that doesn't make sense to us we can always disable that setting. Other configs that I'd consider interesting (but I have 0 experience with) is unicorn and |
One thing I changed in my prettier config for another project was the "print-width". Default it's 80. I suggest something over 120 or so. Otherwise, you will have uncessary wrappings of lines. And today most screens have usually a larger width than a height. |
I'd +1 that, I think the office settings is 120 but perhaps they easily get overwritten. |
notes to myself
|
Eslint + prettifier.
TODO:
The text was updated successfully, but these errors were encountered: