Repository navigation
Commit 54a813d
fix(jans-config-api): address security scan findings (#15616)
* fix(jans-config-api): address security scan findings
Part of #15571.
Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Signed-off-by: moauto <54212639+mo-auto@users.noreply.github.com>
* fix(jans-config-api): address CodeRabbit review
- read enableLock and keep lock record past lockExpTime
- policy-store: count issuer bytes, check iss, accept root issuer file,
validate issuer data via central directory
- mask multiline Cedar strings
- keep total count for limit=0 user search
- skip tknCde path param in audit log
- ignore JSON Patch test ops when detecting clientSecret changes
- allow metadata-only asset updates when upload is disabled
- redact query and user-info from HTTP URI logs
Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Signed-off-by: moauto <54212639+mo-auto@users.noreply.github.com>
* docs(jans-config-api): restore swagger spec
Local build regenerated it from stale artifacts.
Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Signed-off-by: moauto <54212639+mo-auto@users.noreply.github.com>
* fix(jans-config-api): cap lock time, budget zip CD
- Memcached reads TTLs over 30 days as timestamps, so keep the
30-day lock record and cap lockExpTime at 29 days
- count every central-directory entry against the archive budget
Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Signed-off-by: moauto <54212639+mo-auto@users.noreply.github.com>
* feat: address code rabbit comments
Signed-off-by: duttarnab <arnab.bdutta@gmail.com>
* fix(jans-config-api): ignore policy comments in scope map
- Strip Cedar comments before extracting role, resource and actions
- Stop webhook batch on interrupt; log ExecutionException separately
- Use ArrayList for sequentially built parent feature lists
- Register AdminUIService and WebhookService tests in suite
Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Signed-off-by: moauto <54212639+mo-auto@users.noreply.github.com>
* refactor(jans-config-api): simplify policy tokenizer
Reuses stripComments in tokenizePolicy and drops loop-counter writes
to clear Sonar S127/S3776 on the Cedar policy scanner.
Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Signed-off-by: moauto <54212639+mo-auto@users.noreply.github.com>
* fix: address security scan findings
Signed-off-by: duttarnab <arnab.bdutta@gmail.com>
* fet: address code-rabbit comments
Signed-off-by: duttarnab <arnab.bdutta@gmail.com>
* test(jans-config-api): fix AdminUISecurityService tests
- Expect 400 for validation failures thrown before persistence
- Stub web-server host in invalid-archive test
- Stub findEntries for delete not-found
- Rebuild fixture as Cedarling v2 store (metadata.json, schema,
policies) plus the Admin UI trusted-issuer file
Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Signed-off-by: moauto <54212639+mo-auto@users.noreply.github.com>
* fix(jans-config-api): keep admin disable over auto-unlock
Lock record stores the user's updatedAt after locking. Auto-unlock
is refused when the entry changed since, so an administrator disable
made during the lock is not reverted on expiry.
Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Signed-off-by: moauto <54212639+mo-auto@users.noreply.github.com>
* feat(config-api): security scan changes for SMTP and Token endpoint
Signed-off-by: pujavs <pujas.works@gmail.com>
* fix(config-api): Correct token revocation, client secret handling, search validation, TLS pool settings and scopes; simplify archive validation
<!-- coderabbit-ai-generated:v1 -->
* fix(jans-config-api): revoke tokens before session delete
A failed token revocation now leaves the session in place, so the
revoke request can be retried instead of orphaning active tokens.
Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Signed-off-by: moauto <54212639+mo-auto@users.noreply.github.com>
* fix(jans-config-api): address security scan findings
Signed-off-by: pujavs <pujas.works@gmail.com>
* fix: address code-rabbit comments
Signed-off-by: duttarnab <arnab.bdutta@gmail.com>
* fix(jans-config-api): address security scan findings
Signed-off-by: pujavs <pujas.works@gmail.com>
* fix(jans-config-api): address security scan findings
Signed-off-by: pujavs <pujas.works@gmail.com>
* fix(jans-config-api): address security scan findings
Signed-off-by: pujavs <pujas.works@gmail.com>
* refactor(jans-config-api): clear Sonar smells
Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Signed-off-by: moauto <54212639+mo-auto@users.noreply.github.com>
* fix(jans-config-api): address security scan findings
Signed-off-by: pujavs <pujas.works@gmail.com>
* test(jans-config-api): enable info log in audit test
Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Signed-off-by: moauto <54212639+mo-auto@users.noreply.github.com>
---------
Signed-off-by: moauto <54212639+mo-auto@users.noreply.github.com>
Signed-off-by: duttarnab <arnab.bdutta@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Co-authored-by: duttarnab <arnab.bdutta@gmail.com>
Co-authored-by: pujavs <pujas.works@gmail.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>1 parent 3710ed5 commit 54a813d
68 files changed
Lines changed: 2721 additions & 749 deletions
File tree
- jans-config-api
- common/src/main/java/io/jans/configapi
- model/configuration
- util
- docs
- plugins
- admin-ui-plugin
- agama/project
- code
- lib/org/gluu/agama/pw
- jans
- scripts
- src
- main/java/io/jans/ca/plugin/adminui
- filters
- rest
- adminui
- auth
- logging
- service
- adminui
- webhook
- utils
- security
- test
- java/io/jans/ca/plugin/adminui/test
- security
- services
- resources
- json/adminui
- docs
- lock-plugin/src/main/java/io/jans/configapi/plugin/lock/service
- metric-plugin/src/main/java/io/jans/configapi/plugin/metric/util
- scim-plugin/src/main/java/io/jans/configapi/plugin/scim/rest
- shibboleth-plugin/src/main/java/io/jans/configapi/plugin/shibboleth/service
- user-mgt-plugin/src/main/java/io/jans/configapi/plugin/mgt
- rest
- service
- server/src/main
- java/io/jans/configapi
- configuration
- filters
- interceptor
- rest/resource/auth
- security/service
- service/auth
- util
- resources
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
42 | 45 | | |
43 | 46 | | |
44 | 47 | | |
| |||
198 | 201 | | |
199 | 202 | | |
200 | 203 | | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
201 | 212 | | |
202 | 213 | | |
203 | 214 | | |
| |||
465 | 476 | | |
466 | 477 | | |
467 | 478 | | |
468 | | - | |
| 479 | + | |
469 | 480 | | |
470 | 481 | | |
471 | 482 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
165 | 165 | | |
166 | 166 | | |
167 | 167 | | |
| 168 | + | |
| 169 | + | |
168 | 170 | | |
169 | 171 | | |
170 | 172 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13954 | 13954 | | |
13955 | 13955 | | |
13956 | 13956 | | |
13957 | | - | |
13958 | 13957 | | |
13959 | 13958 | | |
13960 | 13959 | | |
| |||
13985 | 13984 | | |
13986 | 13985 | | |
13987 | 13986 | | |
13988 | | - | |
13989 | 13987 | | |
13990 | 13988 | | |
13991 | 13989 | | |
| |||
15695 | 15693 | | |
15696 | 15694 | | |
15697 | 15695 | | |
15698 | | - | |
15699 | | - | |
15700 | | - | |
15701 | | - | |
15702 | 15696 | | |
15703 | 15697 | | |
15704 | 15698 | | |
15705 | 15699 | | |
15706 | | - | |
| 15700 | + | |
15707 | 15701 | | |
15708 | 15702 | | |
15709 | 15703 | | |
15710 | | - | |
| 15704 | + | |
| 15705 | + | |
| 15706 | + | |
| 15707 | + | |
| 15708 | + | |
15711 | 15709 | | |
15712 | 15710 | | |
15713 | 15711 | | |
| |||
16691 | 16689 | | |
16692 | 16690 | | |
16693 | 16691 | | |
16694 | | - | |
16695 | | - | |
16696 | 16692 | | |
16697 | 16693 | | |
16698 | 16694 | | |
| |||
16702 | 16698 | | |
16703 | 16699 | | |
16704 | 16700 | | |
| 16701 | + | |
| 16702 | + | |
16705 | 16703 | | |
16706 | 16704 | | |
16707 | 16705 | | |
| |||
17462 | 17460 | | |
17463 | 17461 | | |
17464 | 17462 | | |
17465 | | - | |
17466 | | - | |
17467 | | - | |
17468 | | - | |
17469 | 17463 | | |
17470 | 17464 | | |
17471 | 17465 | | |
| |||
17699 | 17693 | | |
17700 | 17694 | | |
17701 | 17695 | | |
| 17696 | + | |
| 17697 | + | |
| 17698 | + | |
| 17699 | + | |
17702 | 17700 | | |
17703 | 17701 | | |
17704 | 17702 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
82 | | - | |
| 82 | + | |
83 | 83 | | |
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
| 87 | + | |
| 88 | + | |
87 | 89 | | |
88 | 90 | | |
89 | 91 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| 33 | + | |
| 34 | + | |
33 | 35 | | |
34 | | - | |
| 36 | + | |
35 | 37 | | |
36 | 38 | | |
37 | 39 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
59 | 62 | | |
60 | | - | |
61 | | - | |
| 63 | + | |
| 64 | + | |
62 | 65 | | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
71 | 74 | | |
72 | 75 | | |
73 | 76 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
| 14 | + | |
13 | 15 | | |
14 | 16 | | |
15 | 17 | | |
| |||
0 commit comments