Skip to content

Commit e829e8d

Browse files
authored
feat(jans-shibboleth-idp): trust domain model project pom and checkstyle (#15786)
* chore(jans-shibboleth-idp): added trust-domain module to parent pom #15779 Signed-off-by: Rolain Djeumen <uprightech@gmail.com> * chore(jans-shibboleth-idp): pom and checkstyle for trust-domain #15779 Signed-off-by: Rolain Djeumen <uprightech@gmail.com> --------- Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
1 parent 00a3242 commit e829e8d

3 files changed

Lines changed: 175 additions & 0 deletions

File tree

‎jans-shibboleth-idp/pom.xml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@
6868
<modules>
6969
<module>shib-adapter-kernel</module>
7070
<module>shib-kernel</module>
71+
<module>trust-domain</module>
7172
</modules>
7273

7374
<repositories>
Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
1+
<?xml version="1.0"?>
2+
<!DOCTYPE module PUBLIC
3+
"-//Checkstyle//DTD Checkstyle Configuration 1.3//EN"
4+
"https://checkstyle.org/dtds/configuration_1_3.dtd">
5+
6+
<!--
7+
Focused, semantic-only lint ruleset for jans-shibboleth-idp.
8+
9+
Deliberately NOT a formatting checker: no line-length, brace-placement,
10+
whitespace, naming or Javadoc rules, so it will not fight the existing
11+
code style. Star imports are allowed on purpose (used in TrustRelationship).
12+
13+
Severity is "warning" and the plugin runs with failOnViolation=false, so
14+
these surface in the build log without breaking it. To enforce, raise the
15+
severity below to "error" and set failOnViolation=true in the pom.
16+
-->
17+
<module name="Checker">
18+
19+
<property name="severity" value="warning"/>
20+
<property name="charset" value="UTF-8"/>
21+
<property name="fileExtensions" value="java"/>
22+
23+
<module name="TreeWalker">
24+
25+
<!-- Imports -->
26+
<module name="UnusedImports">
27+
<property name="processJavadoc" value="true"/>
28+
</module>
29+
<module name="RedundantImport"/>
30+
31+
<!-- Dead / redundant code -->
32+
<module name="UnusedLocalVariable"/>
33+
<module name="EmptyStatement"/>
34+
35+
<!-- Correctness smells -->
36+
<module name="EqualsHashCode"/>
37+
<module name="FallThrough"/>
38+
<module name="SimplifyBooleanExpression"/>
39+
<module name="SimplifyBooleanReturn"/>
40+
41+
</module>
42+
43+
</module>
Lines changed: 131 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,131 @@
1+
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
2+
3+
<modelVersion>4.0.0</modelVersion>
4+
<artifactId>jans-shibboleth-trust-domain</artifactId>
5+
<name>Janssen Shibboleth Trust Domain</name>
6+
<description>Domain model for Shibboleth IDP trust relationships — configuration and activation bounded contexts</description>
7+
<packaging>jar</packaging>
8+
9+
<parent>
10+
<groupId>io.jans</groupId>
11+
<artifactId>jans-shibboleth-idp-parent</artifactId>
12+
<version>0.0.0-nightly</version>
13+
</parent>
14+
15+
<dependencies>
16+
<dependency>
17+
<groupId>io.jans</groupId>
18+
<artifactId>jans-shib-kernel</artifactId>
19+
<version>${project.version}</version>
20+
</dependency>
21+
<dependency>
22+
<groupId>org.junit.jupiter</groupId>
23+
<artifactId>junit-jupiter-api</artifactId>
24+
</dependency>
25+
<dependency>
26+
<groupId>org.junit.jupiter</groupId>
27+
<artifactId>junit-jupiter-engine</artifactId>
28+
</dependency>
29+
<dependency>
30+
<groupId>org.junit.jupiter</groupId>
31+
<artifactId>junit-jupiter-params</artifactId>
32+
<scope>test</scope>
33+
</dependency>
34+
<dependency>
35+
<groupId>org.assertj</groupId>
36+
<artifactId>assertj-core</artifactId>
37+
<scope>test</scope>
38+
</dependency>
39+
<dependency>
40+
<groupId>org.mockito</groupId>
41+
<artifactId>mockito-core</artifactId>
42+
<scope>test</scope>
43+
</dependency>
44+
<!--
45+
Compile-time only: provides edu.umd.cs.findbugs.annotations.SuppressFBWarnings,
46+
which appears (retained) in the bytecode of transitive io.jans dependencies.
47+
Without it javac warns it cannot resolve the annotation while reading those
48+
class files. 'provided' scope keeps it off the runtime/packaged classpath.
49+
-->
50+
<dependency>
51+
<groupId>com.github.spotbugs</groupId>
52+
<artifactId>spotbugs-annotations</artifactId>
53+
<scope>provided</scope>
54+
</dependency>
55+
</dependencies>
56+
57+
<build>
58+
<resources>
59+
<resource>
60+
<directory>src/main/resources</directory>
61+
<filtering>true</filtering>
62+
<includes>
63+
<include>**/*.xml</include>
64+
<include>**/services/*</include>
65+
<include>**/*.properties</include>
66+
</includes>
67+
</resource>
68+
</resources>
69+
<testResources>
70+
<testResource>
71+
<directory>src/test/resources</directory>
72+
<filtering>true</filtering>
73+
<includes>
74+
<include>**/*.xml</include>
75+
<include>**/services/*</include>
76+
<include>**/*.properties</include>
77+
</includes>
78+
</testResource>
79+
</testResources>
80+
<plugins>
81+
<!--
82+
Linting only. Compiler version (release/source/target) is intentionally
83+
NOT set here — it is inherited from the parent pom. This block
84+
merges extra -Xlint compiler args onto that inherited configuration.
85+
-->
86+
<plugin>
87+
<groupId>org.apache.maven.plugins</groupId>
88+
<artifactId>maven-compiler-plugin</artifactId>
89+
<configuration>
90+
<showWarnings>true</showWarnings>
91+
<compilerArgs>
92+
<arg>-Xlint:all</arg>
93+
</compilerArgs>
94+
</configuration>
95+
</plugin>
96+
<!--
97+
Checkstyle linting. Reports as warnings only (failOnViolation=false) so it
98+
never breaks the build while the suite is being brought green. Flip
99+
failOnViolation to true (and bump severity to error in checkstyle.xml) to
100+
turn it into an enforced gate later.
101+
-->
102+
<plugin>
103+
<groupId>org.apache.maven.plugins</groupId>
104+
<artifactId>maven-checkstyle-plugin</artifactId>
105+
<version>${maven-checkstyle-plugin.version}</version>
106+
<dependencies>
107+
<dependency>
108+
<groupId>com.puppycrawl.tools</groupId>
109+
<artifactId>checkstyle</artifactId>
110+
<version>${checkstyle.version}</version>
111+
</dependency>
112+
</dependencies>
113+
<configuration>
114+
<configLocation>${project.basedir}/checkstyle.xml</configLocation>
115+
<consoleOutput>true</consoleOutput>
116+
<includeTestSourceDirectory>true</includeTestSourceDirectory>
117+
<failOnViolation>false</failOnViolation>
118+
</configuration>
119+
<executions>
120+
<execution>
121+
<id>checkstyle-lint</id>
122+
<phase>verify</phase>
123+
<goals>
124+
<goal>check</goal>
125+
</goals>
126+
</execution>
127+
</executions>
128+
</plugin>
129+
</plugins>
130+
</build>
131+
</project>

0 commit comments

Comments
 (0)