Having Trouble With Log Processors and New String Id Support

[jekramer]

Hi! I'm currently switching our team's code to take advantage of the string ID support added with PR #3418.

I'm wondering if it's possible that this line would need to switch to use IDHandler.readVertexId? I updated to use string ids and now get errors from a log processor that had previously been running fine. I added the error I'm seeing below:

2023-06-02 20:07:51.197 [pool-9-thread-1] ERROR org.janusgraph.graphdb.log.StandardLogProcessorFramework  - Encountered exception [null] when preparing processor [x] for user log [graph_mutation] on attempt 1 of 1 
2023-06-02 20:07:51.201 [pool-9-thread-1] ERROR org.janusgraph.graphdb.log.StandardLogProcessorFramework  - Full exception:  
java.lang.IllegalArgumentException: null
	at com.google.common.base.Preconditions.checkArgument(Preconditions.java:131)
	at org.janusgraph.diskstorage.util.BufferUtil.readEntry(BufferUtil.java:155)
	at org.janusgraph.graphdb.database.log.TransactionLogHeader$Entry.readModifications(TransactionLogHeader.java:243)
	at org.janusgraph.graphdb.database.log.TransactionLogHeader$Entry.getContentAsModifications(TransactionLogHeader.java:230)
	at org.janusgraph.graphdb.log.StandardLogProcessorFramework$MsgReaderConverter.readRelations(StandardLogProcessorFramework.java:218)
	at org.janusgraph.graphdb.log.StandardLogProcessorFramework$MsgReaderConverter.read(StandardLogProcessorFramework.java:249)
	at org.janusgraph.diskstorage.log.util.ProcessMessageJob.run(ProcessMessageJob.java:46)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:577)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1589)

I can debug further if this is unrelated, but wanted to see if that would explain the issue before going too far down a rabbit hole.

I also noticed that Modification still has outVertexId as a long.

[li-boxuan]

Thanks for trying out the new feature! I appreciate your testing before we officially release it. Yes, what you found is right - we certainly missed testing log processors. Do you want to contribute a patch? If not, I would fix it.

[jekramer]

Nice! I'm not set up for contributing yet so would appreciate it if you don't mind handling this one.

[li-boxuan]

Cool, will let you know once a fix is ready.

[li-boxuan]

@jekramer FYI #3798 is merged to master. If you would be able to test it out for your use case, that would be great!

[jekramer]

tested and it worked! thank you for fixing!

[jekramer]

Closing since this is working well now! Thank you!