-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autocompletion stopped working since upgrading webstrom to 2024.3 for big schema files #729
Comments
@ItaiYosephi Hi! Could you please open a GraphQL tool window and share the errors you see there? |
@vepanimas |
@vepanimas hi, any update on that? |
Hi @ItaiYosephi! Could you please run We're working on optimizing schema building for some unusual projects containing hundreds of non-executable schemas, e.g. for testing purposes. These schemas aren't meant to be used but still significantly degrade performance, so we introduced this heuristic to address the issue. So far, your report is the only one after the latest release, so you probably have an unusually huge schema. Could you share some details about the project? Is it some open API which I can test too? |
And one more question - are all the types in the same single file? If so, maybe we shouldn't count that case as an overflow. |
Hi @vepanimas , |
Hi Hope it is OK I am jumping in here - I am trying to work with Atlassian graphql to fetch Jira only relevant part of the schema and I set this:
I am getting the limit error and I ran I am getting 10859 - is there a way to filter the fetched schema somehow to relevant part only? I tried this:
but the result is the same Thanks |
@JG9A oh, that's a huge schema, I'll look at how it performs. For now, you can change a registry key to increase the predefined limit Also, I noticed that you have an extra colon at the end of the schema path, looks like a typo:
And you can't include or exclude specific types from a schema in the graphql.config, include and exclude keys are specified for files, not for types. |
I'll remove a limit for single files. The intent was not to add up types from multiple different files since, in most cases, they are not intended to be combined into a single executable schema. |
@vepanimas thanks for the quick response. Should I expect the removal of the limit in the next plugin version? Did you tried to use Atlasian GraphQL? I am trying to know if I am doing something wrong and there is a way to create a reduce schema ( not manually) or it is an issue on their side. Again thanks for the help. |
I'll change the logic somehow, probably increasing the limit and skipping the checks for cases with single generated schemas. For now, you can just change a registry setting to any number you need.
I don't see any issues with the schema, it's a problem on the plugin's side. WEB-72019 GraphQL: improve perf optimization for huge schemas |
Describe the bug
Since upgrading Webstorm, there's no autocompletion, no red underline when trying to query for non existing fields, and so on.
UPDATE
Our schema file has a little over 51,000 lines.
If I randomly remove about a 1000 lines, the plugin started working as normal again...
Expected behavior
Schema should be detected properly, autocompletion should work,
Screenshots
Screenshot taken in Webstorm version 2024.2.4, and plugin version 242.21829.3.
Autocomplete is working, and
securityScanSources
has line through indicating it's deprecatedScreenshot taken in Webstorm version 2024.3, and plugin version 243.21565.122:
Only
__typename
is autocompleted, and no line throughVersion and Environment Details
Operation system: MacOS
IDE name and version: Webstorm 2024.3
Plugin version: 243.21565.122
The text was updated successfully, but these errors were encountered: