problems with jinn-tap interface

[pherk]

Context:
FHIR resources have mixed namespaces:

• outer resource 'fhir'
• narratives - which should be edited - 'tei'.

<Composition xmlns="http://hl7.org/fhir">
...
<text xmlns="http://www.tei-c.org/ns/1.0">
  ...
  <div>
    <p>a snippet to be edited</p>
  </div>
  ...
</text>
...
</Composition>

The text narrative is quite complicated so I would like to present the user not the whole document but smaller snippets (div).
A setup with jinn-codemirror works fine but I have to hide the complexity of TEI structure for a nicer user experience.

Problems:

• interfaces of jinn-codemirror (as='node') and jinn-tap (as='xml') are different.
  jinn-codemirror accepts a node: instance()//:tei/:div. This does not work with jinn-tap.
• perhaps in correlation of the first, jinn-tap insists on a body element as a wrapper (//:body/:div).
  With a sole 'div' nothing is displayed . The complete TEI and header structure seems not needed but the body element.
  I have looked into the code of fx-control and also into schema.json of jinn-tap but I have no idea.

                    <div>
                    <!-- works
                        <fx-control ref="." as="node" update-event="leave">
                            <jinn-codemirror mode="xml" class="widget"/>
                        </fx-control>
                        -->
                    <!-- works with the complete example.xml file from the Fore demo -->
                        <div class="jinn-tap-container">
                        <fx-control ref="instance('example')" as="xml" value-prop="xml" update-event="content-change" listen-on="jinn-tap">
                          <jinn-tap class="widget" sidebar=".sidebar"/>
                        </fx-control>
                        <div class="sidebar"/>
                        </div>
                    </div>

[DrRataplan]

Hello there! Have you seen the jinntap demo in Fore already? That one loads a TEI document for editing. It was a chore to tie the APIs together, but it should work. KR Martin

…

On Sat, 10 Jan 2026, 13:20 Peter Herkenrath, ***@***.***> wrote: *pherk* created an issue (Jinntec/Fore#341) <#341> Context: FHIR resources have mixed namespaces: - outer resource 'fhir' - narratives - which should be edited - 'tei'. <Composition xmlns="http://hl7.org/fhir"> ... <text xmlns="http://www.tei-c.org/ns/1.0"> ... <div> <p>a snippet to be edited</p> </div> ... </text> ... </Composition> The text narrative is quite complicated so I would like to present the user not the whole document but smaller snippets (div). A setup with jinn-codemirror works fine but I have to hide the complexity of TEI structure for a nicer user experience. Problems: - interfaces of jinn-codemirror (as='node') and jinn-tap (as='xml') are different. jinn-codemirror accepts a node: instance()//*:tei/*:div. This does not work with jinn-tap. - perhaps in correlation of the first, jinn-tap insists on a body element as a wrapper (//*:body/*:div). With a sole 'div' nothing is displayed . The complete TEI and header structure seems not needed but the body element. I have looked into the code of fx-control and also into schema.json of jinn-tap but I have no idea. <div> <!-- works <fx-control ref="." as="node" update-event="leave"> <jinn-codemirror mode="xml" class="widget"/> </fx-control> --> <!-- works with the complete example.xml file from the Fore demo --> <div class="jinn-tap-container"> <fx-control ref="instance('example')" as="xml" value-prop="xml" update-event="content-change" listen-on="jinn-tap"> <jinn-tap class="widget" sidebar=".sidebar"/> </fx-control> <div class="sidebar"/> </div> </div> — Reply to this email directly, view it on GitHub <#341>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGKEJGSOCJRCS6VBZCVJPT4GDVAFAVCNFSM6AAAAACRIV2RKWVHI2DSMVQWIX3LMV43ASLTON2WKOZTG44TSNRQHA2TAMY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[pherk]

whow, this was fast
yes, I copied the html, js, css and example file from there
regards
Peter

[DrRataplan]

Hey Peter,

Finally circling back on this. Can you verify I understand this correctly?

• FHIR contains narrative elements, containing TEI fragments, starting at the text element.
• Those fragments should be editable with jinntap
• Jinntap wants the document to be rooted at a $doc//tei:text/node()
• Passing the tei:text to jinntap as the context does not work

Can you try passing the whole narrative element to jinntap? And see what happens? If I read the XQuery in jinntap correctly that should work. If not, could you maybe make a github repo with a minimal repro? That might make it easier to reproduce your situation. I'm not that well-versed in FHIR.

KR,

Martin

[pherk]

Hey Martin,
thank you for your interest.

• yes, FHIR contains narratives containing TEI fragments (div's), which should be editable with jinntap.
• Passing tei:div to jinntap as the context does not work.
• Passing tei:body to jinntap as the context works. Regrettably my TEI-Fragments (div's) don't have tei:body wrappers.

My setup is complex (within an TEI-Publisher app); If needed I will produce an MWE.
But similar problem with the demo.
If I reduce the 'tei/example.xml' to div level or alternatively give instance('example')//tei:div as context, the editor shows up but no content will be displayed
If I give instance('example')//tei:body as context for jinntap everything is fine.
The body element (or any wrapper?) seems to be essential.
KR
Peter

[DrRataplan]

Looking at the jinntap code, the wrapper can technically be anything. I know that we are aiming for a bit more schema-agnosticness for jinntap. Allowing it to edit docbook as well, but that is long term. The code handling the wrapper is here: https://github.com/JinnElements/jinn-tap/blob/main/src/util/module.xq#L21.

Jinntap sees 'div' as the highest editable 'chunk'. And it allows adding / removing these 'chunks' Therefore it wants the parent of the divs as the 'root'.

I think if you pass instance('example')//fhir:narrative (the parent of the div), it might work a bit better. Could you give that a go? That does give you multiple divs in a single jinntap, not sure if that's intended. Is it?

Another approach would be to implement a bit more freedom in jinntap for what the root element is. Removing some of the assumptions in there.

For a MWE, an example FHIR document plus some HTML defining the Fore page + toolbar would be more than enough btw.

[pherk]

jinntap can apparently use 'text' or 'body' as wrapper (util/module.xq#L21).

This hampers editing snippets from a bigger TEI document like jinn-codemirror can do.
My problem would be solved, if a div is a possible root with paragraphs as editable chunk's.

<div>
  <p>....</p>
  <p>....</p>
</div>