Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2018 edition support? #48

Open
alex opened this issue Feb 3, 2023 · 2 comments
Open

2018 edition support? #48

alex opened this issue Feb 3, 2023 · 2 comments

Comments

@alex
Copy link

alex commented Feb 3, 2023

Hi, I'm attempting to use ctest2 with a -sys crate that uses edition = "2018", however it looks like that may be unsupported?

The proximate errors I'm seeing are:

error: expected identifier, found keyword crate

I suspect adding new edition support is non-trivial, but I figured I should ask. If adding it is too difficult, it may be worth documenting.

@JohnTitor
Copy link
Owner

It would require a complete rewrite, see #6 (comment) and other issues. I'm afraid I don't have enough time to do this, but I'd love to see any PRs/suggestions/opinions, etc. about it!

@alex
Copy link
Author

alex commented Feb 3, 2023

That's sort of what I was afraid of :-) In the meantime I hacked around crate by replacing it with super (and super::super!) in a few places, so this one came off the front burner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants