Skip to content

🚀 Feature: Run build --no-dts before eslint-doc-generator in blockESLintPlugin #2182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks done
JoshuaKGoldberg opened this issue Apr 8, 2025 · 3 comments · Fixed by #2186
Closed
2 tasks done

🚀 Feature: Run build --no-dts before eslint-doc-generator in blockESLintPlugin #2182

JoshuaKGoldberg opened this issue Apr 8, 2025 · 3 comments · Fixed by #2186
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@JoshuaKGoldberg
Copy link
Owner

Feature Request Checklist

Overview

Coming over from JoshuaKGoldberg/eslint-plugin-package-json#993 (comment), eslint-doc-generator builds require having built source code first. We've resolved to have blockESLintPlugin run pnpm build --no-dts before eslint-doc-generator in its build task.

Additional Info

🎁

Co-authored-by: @michaelfaith
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request labels Apr 8, 2025
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Apr 8, 2025
This was referenced Apr 8, 2025
Merged
Merged
@JoshuaKGoldberg
Copy link
Owner Author

@all-contributors please add @michaelfaith for ideas.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors allcontributors bot mentioned this issue Apr 8, 2025
Open
@allcontributors AllContributors
Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @michaelfaith! 🎉

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2025

🎉 This is included in version v2.37.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
No milestone
1 participant
@JoshuaKGoldberg