Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all probability estimators have an explicit outcome space? #185

Closed
Datseris opened this issue Dec 16, 2022 · 3 comments · Fixed by #187
Closed

Make all probability estimators have an explicit outcome space? #185

Datseris opened this issue Dec 16, 2022 · 3 comments · Fixed by #187
Labels
discussion-design Discussion or design matters high priority
Milestone

Comments

@Datseris
Copy link
Member

It's like 99% sure you'll agree with this @kahaaga , but shall we just go ahead and ensure all probabilities Estimators have a well defined outocme space? Which means, if input x is necessary, it must already be given at the point where the probability estimator is instantiated?

This has numerous benefits:

  1. The estimators always have a well defined outcome_space which is by now an integral part of the API
  2. Maximum entropy is simplified and doesn't need input x.
@Datseris Datseris added high priority discussion-design Discussion or design matters labels Dec 16, 2022
@Datseris Datseris added this to the 2.0 milestone Dec 16, 2022
@kahaaga
Copy link
Member

kahaaga commented Dec 16, 2022

It's like 99% sure you'll agree with this @kahaaga , but shall we just go ahead and ensure all probabilities Estimators have a well defined outocme space? Which means, if input x is necessary, it must already be given at the point where the probability estimator is instantiated?

I think we agreed on this at some point, in some comment, in some PR, somewhere. I'm still totally on board with this.

@Datseris
Copy link
Member Author

Also outcome_space becomes a 1 argument function. ok. we do it then. first things first, #184 first.

@kahaaga
Copy link
Member

kahaaga commented Dec 16, 2022

Yes, let's do one thing at a time, so we don't end up with more conflicting branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion-design Discussion or design matters high priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants