Skip to content

Conversation

araujoms
Copy link
Contributor

Rather ugly but I couldn't think of anything better. Passing along rtol as tol creates an infinite loop because the default rtol is zero.

@codecov
Copy link

codecov bot commented Jul 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.56%. Comparing base (b87fd55) to head (f0c29a5).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
+ Coverage   96.55%   96.56%   +0.01%     
==========================================
  Files          10       10              
  Lines        1450     1455       +5     
==========================================
+ Hits         1400     1405       +5     
  Misses         50       50              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@macd
Copy link

macd commented Oct 17, 2025

What is the status of this? As it stands, one of my packages is broken and I have to run on a fixed local copy of GenericLinearAlgebra

@andreasnoack
Copy link
Member

We should imitate the behavior in LinearAlgebra, see https://github.com/JuliaLang/LinearAlgebra.jl/blob/7e11b5e1b474ff742fb55f420631964b60158fe6/src/svd.jl#L107. @araujoms would you be able to update the PR accordingly?

@araujoms
Copy link
Contributor Author

Sure, done. As it turns out atol and rtol from LinearAlgebra have very a different meaning than GenericLinearAlgebra's tol, which makes for a confusing interface. But that's the life of a pirate.

@andreasnoack
Copy link
Member

Thanks for the changes

...which makes for a confusing interface

Indeed and you know what my fix for this will look like (eventually) 😄

@andreasnoack andreasnoack merged commit ec09e25 into JuliaLinearAlgebra:master Oct 19, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants