Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export withlevel #81

Closed
oxinabox opened this issue Jul 19, 2023 · 3 comments
Closed

export withlevel #81

oxinabox opened this issue Jul 19, 2023 · 3 comments

Comments

@oxinabox
Copy link
Member

oxinabox commented Jul 19, 2023 •
edited
Loading

I feel like since the Logging std lib exports with_logger
we should export withlevel, possibly with the snakecase with_level to match
(and deprecate the old name)
@oxinabox
Copy link
Member Author

@quinnj thoughts, since you introduced it.
Why wasn't it exported initially?

@quinnj
Copy link
Member

quinnj commented Aug 4, 2023

I can't remember exactly other than just trying to be conservative at first to make sure it panned out and worked as expected. I'd be fine exporting and renaming.

@quinnj quinnj mentioned this issue Oct 21, 2024
Open
@quinnj
Copy link
Member

quinnj commented Oct 23, 2024

done in #94

@quinnj quinnj closed this as completed Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@quinnj @oxinabox