-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use _group/_id/level to make it easier to filter out progress log events? #9
Comments
Thanks for the ping. The meaning of However, we don't have a consensus yet and it's possible we should just clarify or generalize |
Is there any consensus on how to handle this yet? I think being able to filter progress log events would be great as it would improve composability of loggers and avoid manually forwarding non-progress logs as in https://github.com/JunoLab/Atom.jl/blob/bf6c20ebfe54ea444ea998f9f58402da2731d31a/src/progress.jl#L61-L67. |
Since |
...although the same docstring says |
Another idea is to use the type of |
Currently there is no easy way to filter out progress log events using
Logging.shouldlog
API. This becomes annoying when usingJULIA_DEBUG
.We can fix this by specifying a custom
_group
. QuotingLogging.@logmsg
:It seems to be a right thing to use here. @c42f Does this match with the design of Logging?
We'd able to use
EarlyFilteredLogger
from LoggingExtras.jl if we implement this.The text was updated successfully, but these errors were encountered: