Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add effect annotations #41

Merged
merged 3 commits into from
Jan 29, 2025
Merged

Add effect annotations #41

merged 3 commits into from
Jan 29, 2025

Conversation

devmotion
Copy link
Member

@devmotion devmotion commented Jan 29, 2025

Fixes #37.
Fixes #40.

With this PR I get:

julia> using IrrationalConstants, BenchmarkTools

julia> @btime 3.0  pi
  1.041 ns (0 allocations: 0 bytes)
true

julia> @btime 3.0  invsqrt2
  1.083 ns (0 allocations: 0 bytes)
false

Note: To keep up with recent changes in Base, additionally #36 is needed which fixes CI.

@coveralls
Copy link

coveralls commented Jan 29, 2025

Pull Request Test Coverage Report for Build 13032954318

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 13032809262: 0.0%
Covered Lines: 70
Relevant Lines: 70

💛 - Coveralls

@devmotion devmotion merged commit 9984b8e into main Jan 29, 2025
6 checks passed
@devmotion devmotion deleted the dw/fix_40 branch January 29, 2025 14:08
@stevengj
Copy link
Member

stevengj commented Jan 29, 2025

Great, thanks! Can we tag a new release? You are way ahead of me: JuliaRegistries/General#123932

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants