Skip to content

Commit a85dc2a

Browse files
authored
Use OIDC for Codecov on GitHub Actions (#120)
The Codecov Action supports OIDC for authentication in place of repository- or organization-level secrets when uploading coverage information. (Tokenless upload is also an option but requires some different configuration.) This commit updates the version of the Codecov Action as well. Reenable `fma` test on Windows to improve coverage, otherwise the entire `fma_emulated` implementation is not covered. While we're at it, add a Codecov badge to the README.
1 parent 78df0c1 commit a85dc2a

3 files changed

Lines changed: 6 additions & 4 deletions

File tree

‎.github/workflows/CI.yml‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ on:
55
branches:
66
- master
77
tags: '*'
8+
permissions:
9+
id-token: write
810
jobs:
911
test:
1012
name: Julia ${{ matrix.version }} - ${{ matrix.os }} - ${{ matrix.arch }} - ${{ github.event_name }}
@@ -38,6 +40,7 @@ jobs:
3840
- uses: julia-actions/julia-buildpkg@v1
3941
- uses: julia-actions/julia-runtest@v1
4042
- uses: julia-actions/julia-processcoverage@v1
41-
- uses: codecov/codecov-action@v5
43+
- uses: codecov/codecov-action@v7
4244
with:
4345
files: lcov.info
46+
use_oidc: true

‎README.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# Quadmath.jl
22

33
[![CI](https://github.com/JuliaMath/Quadmath.jl/actions/workflows/CI.yml/badge.svg)](https://github.com/JuliaMath/Quadmath.jl/actions/workflows/CI.yml)
4+
[![Coverage](https://codecov.io/gh/JuliaMath/Quadmath.jl/branch/master/graph/badge.svg)](https://codecov.io/gh/JuliaMath/Quadmath.jl)
45

56
This is a Julia interface to the IEEE 754 binary128 floating point format, backed by libquadmath (or libm for some architectures). It provides a `Float128` type and associated functionality.
67

‎test/runtests.jl‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -140,9 +140,7 @@ end
140140
@test abs(x) == x
141141
@test hypot(Float128(3),Float128(4)) == Float128(5)
142142
@test atan(x,x) ≈ Float128(pi) / 4
143-
if !Sys.iswindows()
144-
@test fma(x,x,Float128(-1.0)) ≈ Float128(1)
145-
end
143+
@test fma(x,x,Float128(-1.0)) ≈ Float128(1)
146144
@test sin(x) ≈ sin(xd)
147145
@test cos(x) ≈ cos(xd)
148146
@test all(sincos(x) .≈ (sin(x), cos(x)))

0 commit comments

Comments
 (0)