Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEqProblem fails with BFGS and LBFGS #17

Open
longemen3000 opened this issue Aug 3, 2021 · 1 comment
Open

NEqProblem fails with BFGS and LBFGS #17

longemen3000 opened this issue Aug 3, 2021 · 1 comment

Comments

@longemen3000
Copy link
Contributor

longemen3000 commented Aug 3, 2021

if !(scheme.reset_age === nothing)
JFx = factorize(Jx)
else
JFx = nothing
end
asks the scheme for a ´reset_age´ field, but there isnt one. with that, only newton works on NEqProblems. maybe using a function instead of a field access could solve the problem?

@pkofod
Copy link
Member

pkofod commented Aug 4, 2021

I see what you're getting at, but I think everything here should just be annotated Newton. Then, another dispatch can wrap the objective in a meritobjective type and minimize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants