-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why Loopback? #362
Comments
I believe the issue is that the hashes there are tree hashes, not commit hashes. There can be more than one commit that contains the given tree, so tagbot finds the right commit by looking up the registration PR. Tagbot needs the commit hash in order to make the git tag. |
Yeah, that's my understanding. |
Yeah, I realized this as I tried to rewrite TagBot in Julia: ExperimentalTagBot.jl. I think I landed on using the PR title in the General registry to find the right commit. That isn't fully implemented yet, but the core functionality is there I think! At some point in early 2025 I hope to give that another shot, if only to learn more about registries. If any of that code is useful here, that would be great. I think TagBot could be written in Julia with some slightly ugly manual parsing to replace Edit: |
I have recently moved a bunch of Julia packages into monorepo-like projects, and I've consequently had to submit PRs to the
General
registry to change the project repository locations, specify subdirectories, etc. I realized that all of the published versions for a given package are listed in theVersions.toml
file in the registry, and I wondered whyTagBot.jl
uses a loop-back mechanism when all of the version hashes are available in the file?For example, user
@yakir12
on Discourse posted code which only depends onPkg.jl
which reads available package versions. With minimal modification I think this function does what we would need!I apologize if this is the wrong place to ask this question. If folks agree that reading
Versions.toml
would be more convenient, I would be interested in helping to contribute this feature / change.The text was updated successfully, but these errors were encountered: