Skip to content

Commit cd11619

Browse files
authored
Merge pull request #37 from Keyfactor/ab#74456
Ab#74456
2 parents d69f33d + 715dcb6 commit cd11619

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
3.0.2
2+
* Bug Fix - On Management jobs, do not send ACM tags if the certificate is being renewed/replaced
3+
14
3.0.1
25
* Fixed a bug where memory streams closed early before submitting certificates to ACM in Management Add jobs
36
* Fixed a bug where ACM tags would be "set" even if none where entered, preventing a certificate from being added without tags

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,9 @@ However, while the modification/addition of ACM tags is not supported, all exist
5757
This integration is compatible with Keyfactor Universal Orchestrator version 10.1 and later.
5858

5959
## Support
60-
The AWS Certificate Manager (ACM) Universal Orchestrator extension If you have a support issue, please open a support ticket by either contacting your Keyfactor representative or via the Keyfactor Support Portal at https://support.keyfactor.com.
60+
The AWS Certificate Manager (ACM) Universal Orchestrator extension is supported by Keyfactor. If you require support for any issues or have feature request, please open a support ticket by either contacting your Keyfactor representative or via the Keyfactor Support Portal at https://support.keyfactor.com.
6161

62-
> To report a problem or suggest a new feature, use the **[Issues](../../issues)** tab. If you want to contribute actual bug fixes or proposed enhancements, use the **[Pull requests](../../pulls)** tab.
62+
> If you want to contribute bug fixes or additional enhancements, use the **[Pull requests](../../pulls)** tab.
6363
6464
## Requirements & Prerequisites
6565

aws-acm-orchestrator/Jobs/Management.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ internal JobResult PerformAddition(AwsExtensionCredential awsCredentials, Manage
216216
icr.CertificateArn = config.JobCertificate.Alias?.Length >= 20 ? config.JobCertificate.Alias.Trim() : null; //If an arn is provided, use it, this will perform a renewal/replace
217217
Logger.LogTrace($"Certificate arn {icr.CertificateArn}");
218218

219-
if (acmTags != null && acmTags.Count > 0)
219+
if (icr.CertificateArn == null && acmTags != null && acmTags.Count > 0)
220220
{
221221
Logger.LogDebug($"Number of ACM tags added to certificate: {acmTags.Count}");
222222
icr.Tags = acmTags;

0 commit comments

Comments
 (0)