Skip to content

Commit 5d67bb0

Browse files
Add missing peer/dev deps to package.json files (#234)
## Summary: For some reason the 'import/no-extraneous-dependencies' eslint rule isn't actually picking up missing dependencies in the package.json files. I've done a manual audit and added the missing deps. This PR also includes a fix to .eslintrc.js and test.config.js to exclude .DS_Store when computing the list of package names. Issue: None ## Test plan: - yarn build - check build products for the following string: "You are loading the ES modules build of React Router on a page that is already running the CommonJS build, so things won't work right" Author: kevinbarabash Reviewers: jeremywiebe Required Reviewers: Approved By: jeremywiebe Checks: ✅ codecov/project, ✅ Extract i18n strings (ubuntu-latest, 16.x), ✅ Test Coverage (ubuntu-latest, 16.x), ✅ Check builds for changes in size (ubuntu-latest, 16.x), ✅ Check for .changeset file (ubuntu-latest, 16.x), ✅ gerald, ✅ Lint, Flow, and Test (ubuntu-latest, 16.x) Pull Request URL: #234
1 parent 1af0621 commit 5d67bb0

File tree

5 files changed

+28
-10
lines changed

5 files changed

+28
-10
lines changed

.changeset/clean-coins-grow.md

+6
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
"@khanacademy/perseus": patch
3+
"@khanacademy/perseus-editor": patch
4+
---
5+
6+
Add missing deps to peer/dev deps in package.json files

.eslintrc.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,9 @@
22
const fs = require("fs");
33
const path = require("path");
44

5-
const pkgNames = fs.readdirSync(path.join(__dirname, "packages"));
5+
const pkgNames = fs
6+
.readdirSync(path.join(__dirname, "packages"))
7+
.filter((name) => name !== ".DS_Store");
68

79
const pkgAliases = pkgNames.map((pkgName) => {
810
return [`@khanacademy/${pkgName}`, `./packages/${pkgName}/src/index.js`];

config/test/test.config.js

+1
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ const vendorMap = fs
2323

2424
const pkgMap = fs
2525
.readdirSync(path.join(root, "packages"))
26+
.filter((name) => name !== ".DS_Store")
2627
.reduce((map, name) => {
2728
const pkgJson = JSON.parse(
2829
fs.readFileSync(path.join(root, "packages", name, "package.json")),

packages/perseus-editor/package.json

+7
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,13 @@
2121
"test": "bash -c 'yarn --silent --cwd \"../..\" test ${@:0} $($([[ ${@: -1} = -* ]] || [[ ${@: -1} = bash ]]) && echo $PWD)'"
2222
},
2323
"dependencies": {
24+
"@khanacademy/kmath": "^0.0.5",
2425
"@khanacademy/perseus": "^0.2.5"
2526
},
2627
"devDependencies": {
28+
"@khanacademy/wonder-blocks-button": "^2.11.5",
29+
"@khanacademy/wonder-blocks-clickable": "^2.2.6",
30+
"@khanacademy/wonder-blocks-color": "^1.1.20",
2731
"@khanacademy/wonder-blocks-i18n": "^1.2.3",
2832
"aphrodite": "^1.2.5",
2933
"classnames": "^1.1.4",
@@ -36,6 +40,9 @@
3640
"underscore": "^1.4.4"
3741
},
3842
"peerDependencies": {
43+
"@khanacademy/wonder-blocks-button": "^2.11.5",
44+
"@khanacademy/wonder-blocks-clickable": "^2.2.6",
45+
"@khanacademy/wonder-blocks-color": "^1.1.20",
3946
"@khanacademy/wonder-blocks-i18n": "^1.2.3",
4047
"aphrodite": "^1.2.5",
4148
"classnames": "^1.1.4",

packages/perseus/package.json

+11-9
Original file line numberDiff line numberDiff line change
@@ -21,26 +21,27 @@
2121
"test": "bash -c 'yarn --silent --cwd \"../..\" test ${@:0} $($([[ ${@: -1} = -* ]] || [[ ${@: -1} = bash ]]) && echo $PWD)'"
2222
},
2323
"dependencies": {
24-
"@khanacademy/kmath": "0.0.5",
24+
"@khanacademy/kmath": "^0.0.5",
2525
"@khanacademy/math-input": "^0.5.2",
2626
"@khanacademy/kas": "^0.2.4",
2727
"@khanacademy/simple-markdown": "^0.8.2",
2828
"mathquill": "git+https://[email protected]/Khan/mathquill.git#a9ae54e057c5c1acc8244a5627acbff29901d992"
2929
},
3030
"devDependencies": {
31-
"@khanacademy/wonder-blocks-button": "2.11.5",
31+
"@khanacademy/wonder-blocks-button": "^2.11.5",
3232
"@khanacademy/wonder-blocks-color": "^1.1.20",
3333
"@khanacademy/wonder-blocks-core": "^4.3.0",
3434
"@khanacademy/wonder-blocks-data": "^7.0.0",
3535
"@khanacademy/wonder-blocks-dropdown": "^2.6.7",
3636
"@khanacademy/wonder-blocks-i18n": "^1.2.3",
37-
"@khanacademy/wonder-blocks-layout": "1.4.9",
37+
"@khanacademy/wonder-blocks-layout": "^1.4.9",
3838
"@khanacademy/wonder-blocks-link": "^3.8.5",
39+
"@khanacademy/wonder-blocks-modal": "^2.3.1",
3940
"@khanacademy/wonder-blocks-popover": "^1.1.10",
40-
"@khanacademy/wonder-blocks-progress-spinner": "1.1.31",
41+
"@khanacademy/wonder-blocks-progress-spinner": "^1.1.31",
4142
"@khanacademy/wonder-blocks-spacing": "^3.0.5",
4243
"@khanacademy/wonder-blocks-tooltip": "^1.3.10",
43-
"@khanacademy/wonder-blocks-typography": "1.1.31",
44+
"@khanacademy/wonder-blocks-typography": "^1.1.31",
4445
"@khanacademy/wonder-stuff-core": "^0.1.2",
4546
"aphrodite": "^1.2.5",
4647
"classnames": "^1.1.4",
@@ -57,19 +58,20 @@
5758
"underscore": "^1.4.4"
5859
},
5960
"peerDependencies": {
60-
"@khanacademy/wonder-blocks-button": "2.11.5",
61+
"@khanacademy/wonder-blocks-button": "^2.11.5",
6162
"@khanacademy/wonder-blocks-color": "^1.1.20",
6263
"@khanacademy/wonder-blocks-core": "^4.3.0",
6364
"@khanacademy/wonder-blocks-data": "^7.0.0",
6465
"@khanacademy/wonder-blocks-dropdown": "^2.6.7",
6566
"@khanacademy/wonder-blocks-i18n": "^1.2.3",
66-
"@khanacademy/wonder-blocks-layout": "1.4.9",
67+
"@khanacademy/wonder-blocks-layout": "^1.4.9",
6768
"@khanacademy/wonder-blocks-link": "^3.8.5",
69+
"@khanacademy/wonder-blocks-modal": "^2.3.1",
6870
"@khanacademy/wonder-blocks-popover": "^1.1.10",
69-
"@khanacademy/wonder-blocks-progress-spinner": "1.1.31",
71+
"@khanacademy/wonder-blocks-progress-spinner": "^1.1.31",
7072
"@khanacademy/wonder-blocks-spacing": "^3.0.5",
7173
"@khanacademy/wonder-blocks-tooltip": "^1.3.10",
72-
"@khanacademy/wonder-blocks-typography": "1.1.31",
74+
"@khanacademy/wonder-blocks-typography": "^1.1.31",
7375
"@khanacademy/wonder-stuff-core": "^0.1.2",
7476
"aphrodite": "^1.2.5",
7577
"classnames": "^1.1.4",

0 commit comments

Comments
 (0)