Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Novel false-positive behavior on Twitter links #19

Open
dgw opened this issue May 16, 2024 · 0 comments
Open

Novel false-positive behavior on Twitter links #19

dgw opened this issue May 16, 2024 · 0 comments

Comments

@dgw
Copy link

dgw commented May 16, 2024

I have encountered AmputatorBot's API incorrectly returning a "canonical" link for a tweet from a user account ending in "amp":

input:   https://twitter.com/winamp/status/1791121664689725683
# at time of writing, this is a valid tweet
output:  https://twitter.com/winstatus/1791121664689725683
# Twitter in a browser says "Page not found", but the HTTP status is still 200 😡

This is similar to #10, but different enough (triggered by the path component of the link instead of a parameter) that I thought creating a
new issue would be worthwhile. As a workaround, I believe it's safe enough to simply add Twitter to my project's default exclusion list.
dgw added a commit to dgw/sopel-amputator that referenced this issue May 16, 2024
@dgw
Add Twitter/X to default ignore_domains
1b5b68c 
AmputatorBot API treats Twitter links containing "amp" in the username
as AMP and tries to guess a canonical URL, e.g. `/winamp/status/tweetID`
becomes `/winstatus/tweetID`. Adding Twitter/X to the default list
should be a safe workaround.

Reported upstream at jvdburgh/AmputatorBot#19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dgw