You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Selections for the longest time has simply been a source-range with some metadata about what the selection is. this seemed like a neat idea at first but it make sense to use artifacts from our artifactGraph instead.
How selections should work and what the refactor should look like is covered in
Implement convertSelectionToOld and convertSelectionsToOld as utils to help with the refactor
Update Xstate context to use the new types, this will require all the places that consume the types to use the convertSelectionToOld etc utils, though consider converting some of them to use the new types directly if that's easier.
This is what we're aiming for
The "find artifactthat matches sourceRange and type" should be able to use the existing codeToIdSelections function.
The types for the first task has been setup already #3836 note that
From the diagram, don't take id too seriously, like in some of those arrows it might be Artifact that is passed around, so long as the id is on the Artifact we good.
Selections for the longest time has simply been a source-range with some metadata about what the selection is. this seemed like a neat idea at first but it make sense to use artifacts from our artifactGraph instead.
How selections should work and what the refactor should look like is covered in
https://docs.google.com/document/d/16EROjbvGZnBg7Y43yaA36mS4SkC8Cxpm2gpZ1mY2UJo/edit#heading=h.z6ie6kxdgixv
convertSelectionToOld
andconvertSelectionsToOld
as utils to help with the refactorconvertSelectionToOld
etc utils, though consider converting some of them to use the new types directly if that's easier.This is what we're aiming for
The "find artifactthat matches sourceRange and type" should be able to use the existing
codeToIdSelections
function.The types for the first task has been setup already #3836 note that
maybe should be
Instead not sure if one is better than the other.
The text was updated successfully, but these errors were encountered: