Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Helix fails when in "in" units but works in "m" units #3856

Closed
r-barton opened this issue Sep 10, 2024 · 3 comments
Closed

[BUG]: Helix fails when in "in" units but works in "m" units #3856

r-barton opened this issue Sep 10, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@r-barton
Copy link
Contributor

Describe the bug

Changing the unit system causes a helix to fail or pass. The other strange thing I noticed happening is when starting the sketch on the 'XY' plane instead of the custom plane, the helix works in in

Steps to Reproduce

See below for KCL to use. This KCL fails when in in but correctly works in m

// define a plane plane013
const plane013 = {
  plane: {
    origin: [0.000000, 3.000000, 0.000000],
    xAxis: [1.000000, 0.000000, 0.000000],
    yAxis: [-0.000000, 0.000000, 1.000000],
    zAxis: [-0.000000, 1.000000, -0.000000]
  }
}

// create a sketch sketch002
const sketch002 = startSketchOn(plane013)

// create sketch profile sketch002Profile000
const sketch002Profile000 = circle([0.000000, 0.000000], 0.125000, sketch002, $arc001)

// create a helix helix001
const helix001 = extrude(-0.42500000000000004, sketch002Profile000)
  |> helix({
       angleStart: 0.0,
       ccw: false,
       revolutions: 8.5
     }, %)

Expected Behavior

This code should work regardless of the unit set or custom plane used.

Screenshots and Recordings

No response

Desktop OS

Windows

Browser

Chrome

Version

v0.25.1

Additional Context

No response

@r-barton r-barton added the bug Something isn't working label Sep 10, 2024
@jessfraz
Copy link
Contributor

cc @gserena01 who might have ideas on the engine side I cant think of anything we might be doing in kcl

@jessfraz
Copy link
Contributor

do we need to call "EnableSketchMode" before doing a helix? maybe that is it?

@jessfraz jessfraz added this to the v1 Modeling App Launch milestone Sep 11, 2024
@gserena01
Copy link
Contributor

We don't need to be in sketch mode to add a helix... something else must be happening here. I'll investigate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants