-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(1) Fix place quantified name retrieval issues (2) Use s2 cell-based search for all hazard search scenarios #274
Conversation
Looks great! In this area, since This line looks off to me since Something seems off with the quantified name merge because some of the code that I wrote for that is getting reverted in this PR. For example, this was changed to use Can we also delete the code that was commented out? I think it's safe to get rid of it if we're not using it. |
@ThomasThelen The commented codes are now removed. The issue that I solved with placeQuantName is to use group_concat for the retrieval. That is why in the line you highlighted I have to split the processed place_name into an array. |
Thanks for removing it! From what I understand, quantified name isn't broken in stko-kwg, which is why I don't like seeing any changes to that area of the code here. The group concat for placeQuantName in your branch is the same as the one in stko-kwg except in your branch it moved position in the query projection (do a ctl+f search for |
@ThomasThelen Oh no! Definitely something is wrong here. I merged stko-kwg to my branch before, but it didn't contain your changes. So I thought I should fix it, and now it turns out that something lost during the merge. |
My guess is the auto merge chose the changes on your branch vs the ones on stko-kwg. I would save your work in this branch, revert your branch back to before that merge, then do the merge and add your work in |
@ThomasThelen Thanks! |
I finished testing this and it looks great! Glad we were able to get rid of some of the complexity in the query generation code too |
(1) Fix place quantified name retrieval issues (2) Use s2 cell-based search for all hazard search scenarios