Skip to content

update default bodyType of Issue/Comments and Repository/Comments #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

update default bodyType of Issue/Comments and Repository/Comments #551

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a198c48
update default bodyType of Issue/Comments and Repository/Comments con…
bobeagan Mar 27, 2017
bd6d704
Merge branch 'master' into breaking-change/update-default-bodytype
bobeagan Jul 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/Github/Api/Issue/Comments.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ class Comments extends AbstractApi
*/
public function configure($bodyType = null)
{
if (!in_array($bodyType, array('raw', 'text', 'html'))) {
$bodyType = 'full';
if (!in_array($bodyType, array('text', 'html', 'full'))) {
$bodyType = 'raw';
}

$this->acceptHeaderValue = sprintf('application/vnd.github.%s.%s+json', $this->client->getApiVersion(), $bodyType);
Expand Down
4 changes: 2 additions & 2 deletions lib/Github/Api/Repository/Comments.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ class Comments extends AbstractApi
*/
public function configure($bodyType = null)
{
if (!in_array($bodyType, array('raw', 'text', 'html'))) {
$bodyType = 'full';
if (!in_array($bodyType, array('text', 'html', 'full'))) {
$bodyType = 'raw';
}

$this->acceptHeaderValue = sprintf('application/vnd.github.%s.%s+json', $this->client->getApiVersion(), $bodyType);
Expand Down